You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/08/04 09:04:54 UTC
[GitHub] [flink] zentol opened a new pull request #16702: [FLINK-23610][tests] Harden DefaultSchedulerTest
zentol opened a new pull request #16702:
URL: https://github.com/apache/flink/pull/16702
Hardens the test by removing a sleep.. Instead we wait for a certain number of events to occur.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16702: [FLINK-23610][tests] Harden DefaultSchedulerTest
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16702:
URL: https://github.com/apache/flink/pull/16702#issuecomment-892516601
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ca941979d705ceffd5075b2e251e1cb8f2b7a7db",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21492",
"triggerID" : "ca941979d705ceffd5075b2e251e1cb8f2b7a7db",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ca941979d705ceffd5075b2e251e1cb8f2b7a7db Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21492)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16702: [FLINK-23610][tests] Harden DefaultSchedulerTest
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16702:
URL: https://github.com/apache/flink/pull/16702#issuecomment-892496130
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 080b0c32f9d648593687007505d83e508ecca93f (Sat Aug 28 13:10:24 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dmvk commented on a change in pull request #16702: [FLINK-23610][tests] Harden DefaultSchedulerTest
Posted by GitBox <gi...@apache.org>.
dmvk commented on a change in pull request #16702:
URL: https://github.com/apache/flink/pull/16702#discussion_r683544350
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/TestExecutionVertexOperationsDecorator.java
##########
@@ -82,14 +82,52 @@ public void disableFailDeploy() {
}
public List<ExecutionVertexID> getDeployedVertices() {
- return Collections.unmodifiableList(deployedVertices);
+ return deployedVertices.getVertices();
}
public List<ExecutionVertexID> getCanceledVertices() {
- return Collections.unmodifiableList(canceledVertices);
+ return canceledVertices.getVertices();
}
public List<ExecutionVertexID> getFailedVertices() {
- return Collections.unmodifiableList(failedVertices);
+ return failedVertices.getVertices();
+ }
+
+ /** Waits until the given number of vertices have been canceled. */
+ public void awaitCanceledVertices(int count) throws InterruptedException {
+ canceledVertices.await(count);
+ }
+
+ /** Waits until the given number of vertices have been failed. */
+ public void awaitFailedVertices(int count) throws InterruptedException {
+ failedVertices.await(count);
+ }
+
+ private static class CountLatch {
+ @GuardedBy("lock")
+ private final List<ExecutionVertexID> vertices = new ArrayList<>();
+
+ private final Object lock = new Object();
+
+ public void add(ExecutionVertexID executionVertexId) {
+ synchronized (lock) {
+ vertices.add(executionVertexId);
+ lock.notifyAll();
+ }
+ }
+
+ public void await(int count) throws InterruptedException {
+ synchronized (lock) {
+ while (vertices.size() != count) {
Review comment:
```suggestion
while (vertices.size() < count) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16702: [FLINK-23610][tests] Harden DefaultSchedulerTest
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16702:
URL: https://github.com/apache/flink/pull/16702#issuecomment-892496130
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit ca941979d705ceffd5075b2e251e1cb8f2b7a7db (Wed Aug 04 09:08:55 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16702: [FLINK-23610][tests] Harden DefaultSchedulerTest
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16702:
URL: https://github.com/apache/flink/pull/16702#issuecomment-892516601
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ca941979d705ceffd5075b2e251e1cb8f2b7a7db",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ca941979d705ceffd5075b2e251e1cb8f2b7a7db",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ca941979d705ceffd5075b2e251e1cb8f2b7a7db UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16702: [FLINK-23610][tests] Harden DefaultSchedulerTest
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16702:
URL: https://github.com/apache/flink/pull/16702#issuecomment-892516601
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16702: [FLINK-23610][tests] Harden DefaultSchedulerTest
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16702:
URL: https://github.com/apache/flink/pull/16702#issuecomment-892516601
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ca941979d705ceffd5075b2e251e1cb8f2b7a7db",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ca941979d705ceffd5075b2e251e1cb8f2b7a7db",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ca941979d705ceffd5075b2e251e1cb8f2b7a7db UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol merged pull request #16702: [FLINK-23610][tests] Harden DefaultSchedulerTest
Posted by GitBox <gi...@apache.org>.
zentol merged pull request #16702:
URL: https://github.com/apache/flink/pull/16702
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16702: [FLINK-23610][tests] Harden DefaultSchedulerTest
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16702:
URL: https://github.com/apache/flink/pull/16702#issuecomment-892516601
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ca941979d705ceffd5075b2e251e1cb8f2b7a7db",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21492",
"triggerID" : "ca941979d705ceffd5075b2e251e1cb8f2b7a7db",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ca941979d705ceffd5075b2e251e1cb8f2b7a7db Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21492)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org