You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/11/24 15:12:12 UTC
[GitHub] [incubator-superset] kgabryje edited a comment on pull request #11766: fix: Chart select borders in BuilderComponentPane
kgabryje edited a comment on pull request #11766:
URL: https://github.com/apache/incubator-superset/pull/11766#issuecomment-733034617
> @kgabryje What you've got works, and keeps the design as is. That said, I kind of like the added line height, even if it was a side effect! If we want to keep that, a simpler solution to the "bug" seems to be removing `rowHeight` from the props passed into `<List ...>` on line 239 of `SliceAdder.jsx`. That would mean we can delete the `DEFAULT_CELL_HEIGHT` which is the root source of the cropping problem we see in the attached issue. What do you think?
There is a side-side effect - disabled charts have a different border colour and it looks rather strange when they are next to enabled charts. Here's a screenshot when border-bottom was set to none (to fix double border effect which was also mentioned in the issue).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org