You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/07 12:58:26 UTC

[GitHub] [airflow] ashb commented on a change in pull request #20104: Helper for provide_session-decorated functions

ashb commented on a change in pull request #20104:
URL: https://github.com/apache/airflow/pull/20104#discussion_r763967061



##########
File path: airflow/settings.py
##########
@@ -77,7 +80,7 @@
 DAGS_FOLDER: str = os.path.expanduser(conf.get('core', 'DAGS_FOLDER'))
 
 engine: Optional[Engine] = None
-Session: Optional[SASession] = None
+Session: Callable[..., SASession]

Review comment:
       This will conflict with https://github.com/apache/airflow/pull/20000 (and also , the SessionMaker is both callable, _and_ behaves like an actual Session. SQLA is weird like that)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org