You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@plc4x.apache.org by Lukas Ott <ot...@gmail.com> on 2020/12/13 15:52:35 UTC
[VOTE] Apache PLC4X Build-Tools Code-Generation 1.4.0 RC2
Apache PLC4X Build-Tools Code-Generation 1.4.0 has been staged under [2]
and it’s time to vote on accepting it for release.
All Maven artifacts are available under [1]. Voting will be open for
72hr.
A minimum of 3 binding +1 votes and more binding +1 than binding -1
are required to pass.
Repository: https://gitbox.apache.org/repos/asf/plc4x-build-tools.git
Release tag: releases/code-generation/1.4.0
Hash for the release tag: {replacethiswiththerealgitcommittag}
Per [3] "Before voting +1 PMC members are required to download
the signed source code package, compile it as provided, and test
the resulting executable on their own platform, along with also
verifying that the package meets the requirements of the ASF policy
on releases."
You can achieve the above by following [4].
[ ] +1 accept (indicate what you validated - e.g. performed the non-RM
items in [4])
[ ] -1 reject (explanation required)
[1]
https://repository.apache.org/content/repositories/orgapacheplc4x-{somefourdigitnumber}
[2]
https://dist.apache.org/repos/dist/dev/plc4x/build-tools/code-generation/1.4.0/rc2/
[3]
https://www.apache.org/dev/release/validation.html#approving-a-release
[4] https://plc4x.apache.org/developers/release/validation.html
AW: [VOTE] Apache PLC4X Build-Tools Code-Generation 1.4.0 RC2
Posted by Christofer Dutz <ch...@c-ware.de>.
+1 (binding)
Run on Windows 10 Professional x64 with Java:
openjdk 11.0.9.1 2020-11-04 LTS
OpenJDK Runtime Environment 18.9 (build 11.0.9.1+1-LTS)
OpenJDK 64-Bit Server VM 18.9 (build 11.0.9.1+1-LTS, mixed mode)
[OK] Download all staged artifacts under the url specified in the release vote email
[MINOR] Verify the signature is correct
[OK] Check if the signature references an Apache email address.
[OK] Verify the SHA512 hashes
[OK] Unzip the archive
[OK] Verify the existence of LICENSE, NOTICE, README, RELEASE_NOTES files in the extracted source bundle
[OK] Verify the content of LICENSE, NOTICE, README, RELEASE_NOTES files in the extracted source bundle
[OK] Verify the staged source README, RELEASE_NOTE files correspond to those in the extracted source bundle
[OK] Run RAT externally to ensure there are no surprises
[OK] Search for SNAPSHOT references
[OK] Search for Copyright references, and if they are in headers, make sure these files containing them are mentioned in the LICENSE file
[OK] Build the project according to the information in the README.md file
The next time we all meet, we should do the key signing to get rid of not being able to "trust" the signature.
-----Ursprüngliche Nachricht-----
Von: Otto Fowler <ot...@gmail.com>
Gesendet: Montag, 14. Dezember 2020 16:04
An: dev@plc4x.apache.org
Betreff: Re: [VOTE] Apache PLC4X Build-Tools Code-Generation 1.4.0 RC2
+1 binding
java version "1.8.0_171"
Java(TM) SE Runtime Environment (build 1.8.0_171-b11) Java HotSpot(TM) 64-Bit Server VM (build 25.171-b11, mixed mode)
> On Dec 13, 2020, at 10:52, Lukas Ott <ot...@gmail.com> wrote:
>
> Apache PLC4X Build-Tools Code-Generation 1.4.0 has been staged under [2]
> and it’s time to vote on accepting it for release.
>
> All Maven artifacts are available under [1]. Voting will be open for
> 72hr.
>
> A minimum of 3 binding +1 votes and more binding +1 than binding -1
> are required to pass.
>
> Repository: https://gitbox.apache.org/repos/asf/plc4x-build-tools.git
> Release tag: releases/code-generation/1.4.0
> Hash for the release tag: {replacethiswiththerealgitcommittag}
>
> Per [3] "Before voting +1 PMC members are required to download
> the signed source code package, compile it as provided, and test
> the resulting executable on their own platform, along with also
> verifying that the package meets the requirements of the ASF policy
> on releases."
>
> You can achieve the above by following [4].
>
> [ ] +1 accept (indicate what you validated - e.g. performed the
> non-RM items in [4])
> [ ] -1 reject (explanation required)
>
>
> [1]
> https://repository.apache.org/content/repositories/orgapacheplc4x-{somefourdigitnumber}
> [2]
> https://dist.apache.org/repos/dist/dev/plc4x/build-tools/code-generation/1.4.0/rc2/
> [3]
> https://www.apache.org/dev/release/validation.html#approving-a-release
> [4] https://plc4x.apache.org/developers/release/validation.html
Re: [VOTE] Apache PLC4X Build-Tools Code-Generation 1.4.0 RC2
Posted by Otto Fowler <ot...@gmail.com>.
+1 binding
java version "1.8.0_171"
Java(TM) SE Runtime Environment (build 1.8.0_171-b11)
Java HotSpot(TM) 64-Bit Server VM (build 25.171-b11, mixed mode)
> On Dec 13, 2020, at 10:52, Lukas Ott <ot...@gmail.com> wrote:
>
> Apache PLC4X Build-Tools Code-Generation 1.4.0 has been staged under [2]
> and it’s time to vote on accepting it for release.
>
> All Maven artifacts are available under [1]. Voting will be open for
> 72hr.
>
> A minimum of 3 binding +1 votes and more binding +1 than binding -1
> are required to pass.
>
> Repository: https://gitbox.apache.org/repos/asf/plc4x-build-tools.git
> Release tag: releases/code-generation/1.4.0
> Hash for the release tag: {replacethiswiththerealgitcommittag}
>
> Per [3] "Before voting +1 PMC members are required to download
> the signed source code package, compile it as provided, and test
> the resulting executable on their own platform, along with also
> verifying that the package meets the requirements of the ASF policy
> on releases."
>
> You can achieve the above by following [4].
>
> [ ] +1 accept (indicate what you validated - e.g. performed the non-RM
> items in [4])
> [ ] -1 reject (explanation required)
>
>
> [1]
> https://repository.apache.org/content/repositories/orgapacheplc4x-{somefourdigitnumber}
> [2]
> https://dist.apache.org/repos/dist/dev/plc4x/build-tools/code-generation/1.4.0/rc2/
> [3]
> https://www.apache.org/dev/release/validation.html#approving-a-release
> [4] https://plc4x.apache.org/developers/release/validation.html
Re: [VOTE] Apache PLC4X Build-Tools Code-Generation 1.4.0 RC2
Posted by Ben Hutcheson <be...@gmail.com>.
+1 (binding)
Was able to build, test and build the main repository with the 1.4.0
version just fine.
Other comments, I don't see as show stoppers.
- an sha1 instead of a sha512 is available, we might need to update the
documentation at https://plc4x.apache.org/developers/release/validation.html.
It shows the command to generate the sha512 of the zip file but doesn't
tell you to compare that with the downloaded sha512 file. (or in this case
the sha1 file)
- the zip file is spelled incorrectly, generaton instead of generation.
Apache Maven 3.6.3
Maven home: /usr/share/maven
Java version: 11.0.8, vendor: Debian, runtime:
/usr/lib/jvm/java-11-openjdk-amd64
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "5.8.0-2-amd64", arch: "amd64", family: "unix"
On Mon, Dec 14, 2020 at 1:55 AM Lukas Ott <ot...@gmail.com> wrote:
> +1 (binding)
>
> 1) Verified:
> $gpg --verify apache-plc4x-code-generation-1.4.0-source-release.zip.asc
> apache-plc4x-code-generation-1.4.0-source-release.zip
> gpg: Signatur vom So 13 Dez 2020 17:39:46 CET
> gpg: mittels RSA-Schlüssel
> B6AC3BF1A0F08554144EEC56027975C99CBA22C7
> gpg: Korrekte Signatur von "Lukas Ott <ot...@apache.org>" [ultimativ]
> 2)
> $ shasum -a512 apache-plc4x-code-generation-1.4.0-source-release.zip
>
> 7a906395077f34cbb6c0d66241d17784c9ad7077d8533553fee7cd2d2cae0e8877933969fe3424f29f32af2094af952067ca3887adf178fe08e5f012f77a412f
> apache-plc4x-code-generation-1.4.0-source-release.zip
> 3) Checked Readme and Release Notes
> 4) Can build from source
> $ chmod +x mvnw
> $ ./mvnw install
>
> 5) Checked Licence
>
> OS: Ubuntu 20.04.1 LTS
> $ mvn -version
> Apache Maven 3.6.3
> Maven home: /usr/share/maven
> Java version: 11.0.9.1, vendor: Ubuntu, runtime:
> /usr/lib/jvm/java-11-openjdk-amd64
> Default locale: de_DE, platform encoding: UTF-8
> OS name: "linux", version: "5.4.0-58-generic", arch: "amd64", family:
> "unix"
>
> No further remarks
>
>
> Am So., 13. Dez. 2020 um 16:56 Uhr schrieb Lukas Ott <
> ott.lukas.14@gmail.com
> >:
>
> > URL for Source [1]
> > https://repository.apache.org/content/repositories/orgapacheplc4x-1031/
> >
> > Am So., 13. Dez. 2020 um 16:52 Uhr schrieb Lukas Ott <
> > ott.lukas.14@gmail.com>:
> >
> >> Apache PLC4X Build-Tools Code-Generation 1.4.0 has been staged under
> [2]
> >> and it’s time to vote on accepting it for release.
> >>
> >> All Maven artifacts are available under [1]. Voting will be open for
> >> 72hr.
> >>
> >> A minimum of 3 binding +1 votes and more binding +1 than binding -1
> >> are required to pass.
> >>
> >> Repository:
> https://gitbox.apache.org/repos/asf/plc4x-build-tools.git
> >> Release tag: releases/code-generation/1.4.0
> >> Hash for the release tag: {replacethiswiththerealgitcommittag}
> >>
> >> Per [3] "Before voting +1 PMC members are required to download
> >> the signed source code package, compile it as provided, and test
> >> the resulting executable on their own platform, along with also
> >> verifying that the package meets the requirements of the ASF policy
> >> on releases."
> >>
> >> You can achieve the above by following [4].
> >>
> >> [ ] +1 accept (indicate what you validated - e.g. performed the
> >> non-RM items in [4])
> >> [ ] -1 reject (explanation required)
> >>
> >>
> >> [1]
> >>
> https://repository.apache.org/content/repositories/orgapacheplc4x-{somefourdigitnumber}
> >> [2]
> >>
> https://dist.apache.org/repos/dist/dev/plc4x/build-tools/code-generation/1.4.0/rc2/
> >> [3]
> >> https://www.apache.org/dev/release/validation.html#approving-a-release
> >> [4] https://plc4x.apache.org/developers/release/validation.html
> >>
> >
>
Re: [VOTE] Apache PLC4X Build-Tools Code-Generation 1.4.0 RC2
Posted by Lukas Ott <ot...@gmail.com>.
+1 (binding)
1) Verified:
$gpg --verify apache-plc4x-code-generation-1.4.0-source-release.zip.asc
apache-plc4x-code-generation-1.4.0-source-release.zip
gpg: Signatur vom So 13 Dez 2020 17:39:46 CET
gpg: mittels RSA-Schlüssel
B6AC3BF1A0F08554144EEC56027975C99CBA22C7
gpg: Korrekte Signatur von "Lukas Ott <ot...@apache.org>" [ultimativ]
2)
$ shasum -a512 apache-plc4x-code-generation-1.4.0-source-release.zip
7a906395077f34cbb6c0d66241d17784c9ad7077d8533553fee7cd2d2cae0e8877933969fe3424f29f32af2094af952067ca3887adf178fe08e5f012f77a412f
apache-plc4x-code-generation-1.4.0-source-release.zip
3) Checked Readme and Release Notes
4) Can build from source
$ chmod +x mvnw
$ ./mvnw install
5) Checked Licence
OS: Ubuntu 20.04.1 LTS
$ mvn -version
Apache Maven 3.6.3
Maven home: /usr/share/maven
Java version: 11.0.9.1, vendor: Ubuntu, runtime:
/usr/lib/jvm/java-11-openjdk-amd64
Default locale: de_DE, platform encoding: UTF-8
OS name: "linux", version: "5.4.0-58-generic", arch: "amd64", family: "unix"
No further remarks
Am So., 13. Dez. 2020 um 16:56 Uhr schrieb Lukas Ott <ott.lukas.14@gmail.com
>:
> URL for Source [1]
> https://repository.apache.org/content/repositories/orgapacheplc4x-1031/
>
> Am So., 13. Dez. 2020 um 16:52 Uhr schrieb Lukas Ott <
> ott.lukas.14@gmail.com>:
>
>> Apache PLC4X Build-Tools Code-Generation 1.4.0 has been staged under [2]
>> and it’s time to vote on accepting it for release.
>>
>> All Maven artifacts are available under [1]. Voting will be open for
>> 72hr.
>>
>> A minimum of 3 binding +1 votes and more binding +1 than binding -1
>> are required to pass.
>>
>> Repository: https://gitbox.apache.org/repos/asf/plc4x-build-tools.git
>> Release tag: releases/code-generation/1.4.0
>> Hash for the release tag: {replacethiswiththerealgitcommittag}
>>
>> Per [3] "Before voting +1 PMC members are required to download
>> the signed source code package, compile it as provided, and test
>> the resulting executable on their own platform, along with also
>> verifying that the package meets the requirements of the ASF policy
>> on releases."
>>
>> You can achieve the above by following [4].
>>
>> [ ] +1 accept (indicate what you validated - e.g. performed the
>> non-RM items in [4])
>> [ ] -1 reject (explanation required)
>>
>>
>> [1]
>> https://repository.apache.org/content/repositories/orgapacheplc4x-{somefourdigitnumber}
>> [2]
>> https://dist.apache.org/repos/dist/dev/plc4x/build-tools/code-generation/1.4.0/rc2/
>> [3]
>> https://www.apache.org/dev/release/validation.html#approving-a-release
>> [4] https://plc4x.apache.org/developers/release/validation.html
>>
>
Re: [VOTE] Apache PLC4X Build-Tools Code-Generation 1.4.0 RC2
Posted by Lukas Ott <ot...@gmail.com>.
URL for Source [1]
https://repository.apache.org/content/repositories/orgapacheplc4x-1031/
Am So., 13. Dez. 2020 um 16:52 Uhr schrieb Lukas Ott <ott.lukas.14@gmail.com
>:
> Apache PLC4X Build-Tools Code-Generation 1.4.0 has been staged under [2]
> and it’s time to vote on accepting it for release.
>
> All Maven artifacts are available under [1]. Voting will be open for
> 72hr.
>
> A minimum of 3 binding +1 votes and more binding +1 than binding -1
> are required to pass.
>
> Repository: https://gitbox.apache.org/repos/asf/plc4x-build-tools.git
> Release tag: releases/code-generation/1.4.0
> Hash for the release tag: {replacethiswiththerealgitcommittag}
>
> Per [3] "Before voting +1 PMC members are required to download
> the signed source code package, compile it as provided, and test
> the resulting executable on their own platform, along with also
> verifying that the package meets the requirements of the ASF policy
> on releases."
>
> You can achieve the above by following [4].
>
> [ ] +1 accept (indicate what you validated - e.g. performed the non-RM
> items in [4])
> [ ] -1 reject (explanation required)
>
>
> [1]
> https://repository.apache.org/content/repositories/orgapacheplc4x-{somefourdigitnumber}
> [2]
> https://dist.apache.org/repos/dist/dev/plc4x/build-tools/code-generation/1.4.0/rc2/
> [3]
> https://www.apache.org/dev/release/validation.html#approving-a-release
> [4] https://plc4x.apache.org/developers/release/validation.html
>