You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by "Virag Kothari (Created) (JIRA)" <ji...@apache.org> on 2012/01/10 01:55:39 UTC
[jira] [Created] (OOZIE-651) Coordinator rerun fails due to NPE in
some cases
Coordinator rerun fails due to NPE in some cases
------------------------------------------------
Key: OOZIE-651
URL: https://issues.apache.org/jira/browse/OOZIE-651
Project: Oozie
Issue Type: Bug
Reporter: Virag Kothari
CoordinatorActionInfo coordInfo = coordEngine.reRun(jobId, rerunType, scope, Boolean.valueOf(refresh),
Boolean.valueOf(noCleanup));
coordActions = coordInfo.getCoordActions();
The Coordinator rerun command requires to acquire the lock before it executes. If it cant get the lock, then it is queued. In this case the return value, the coordInfo, is null. Trying to access the coordInfo causes NPE in such a case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-651) Coordinator rerun fails due to NPE
in some cases
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185335#comment-13185335 ]
jiraposter@reviews.apache.org commented on OOZIE-651:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3441/#review4342
-----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/coord/CoordUtils.java
<https://reviews.apache.org/r/3441/#comment9780>
ok
trunk/core/src/main/java/org/apache/oozie/coord/CoordUtils.java
<https://reviews.apache.org/r/3441/#comment9781>
ok
trunk/core/src/main/java/org/apache/oozie/coord/CoordUtils.java
<https://reviews.apache.org/r/3441/#comment9782>
ok
trunk/core/src/main/java/org/apache/oozie/coord/CoordUtils.java
<https://reviews.apache.org/r/3441/#comment9783>
ok
trunk/core/src/main/java/org/apache/oozie/coord/CoordUtils.java
<https://reviews.apache.org/r/3441/#comment9784>
ok
trunk/core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java
<https://reviews.apache.org/r/3441/#comment9785>
ok
- Virag
On 2012-01-10 02:05:54, Virag Kothari wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3441/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-01-10 02:05:54)
bq.
bq.
bq. Review request for oozie, Mohammad Islam and Angelo K. Huang.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. https://issues.apache.org/jira/browse/OOZIE-651
bq.
bq.
bq. This addresses bug OOZIE-651.
bq. https://issues.apache.org/jira/browse/OOZIE-651
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/core/src/main/java/org/apache/oozie/LocalOozieClientCoord.java 1229389
bq. trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1229389
bq. trunk/core/src/main/java/org/apache/oozie/coord/CoordUtils.java 1229389
bq. trunk/core/src/main/java/org/apache/oozie/servlet/JobServlet.java 1229389
bq. trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1229389
bq. trunk/core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java 1229389
bq. trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java 1229389
bq. trunk/core/src/test/java/org/apache/oozie/coord/TestCoordUtils.java PRE-CREATION
bq. trunk/docs/src/site/twiki/DG_CoordinatorRerun.twiki 1229389
bq.
bq. Diff: https://reviews.apache.org/r/3441/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Tested against current test cases
bq. Test cases for CoordUtils added
bq. Ran the coordinator rerun example
bq.
bq.
bq. Thanks,
bq.
bq. Virag
bq.
bq.
> Coordinator rerun fails due to NPE in some cases
> ------------------------------------------------
>
> Key: OOZIE-651
> URL: https://issues.apache.org/jira/browse/OOZIE-651
> Project: Oozie
> Issue Type: Bug
> Reporter: Virag Kothari
>
> CoordinatorActionInfo coordInfo = coordEngine.reRun(jobId, rerunType, scope, Boolean.valueOf(refresh),
> Boolean.valueOf(noCleanup));
> coordActions = coordInfo.getCoordActions();
> The Coordinator rerun command requires to acquire the lock before it executes. If it cant get the lock, then it is queued. In this case the return value, the coordInfo, is null. Trying to access the coordInfo causes NPE in such a case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-651) Coordinator rerun fails due to NPE
in some cases
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13192017#comment-13192017 ]
jiraposter@reviews.apache.org commented on OOZIE-651:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3441/#review4552
-----------------------------------------------------------
Ship it!
+1 committing
- Mohammad
On 2012-01-13 00:21:17, Virag Kothari wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3441/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-01-13 00:21:17)
bq.
bq.
bq. Review request for oozie, Mohammad Islam and Angelo K. Huang.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. https://issues.apache.org/jira/browse/OOZIE-651
bq.
bq.
bq. This addresses bug OOZIE-651.
bq. https://issues.apache.org/jira/browse/OOZIE-651
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/core/src/main/java/org/apache/oozie/LocalOozieClientCoord.java 1229389
bq. trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1229389
bq. trunk/core/src/main/java/org/apache/oozie/coord/CoordUtils.java 1229389
bq. trunk/core/src/main/java/org/apache/oozie/servlet/JobServlet.java 1229389
bq. trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1229389
bq. trunk/core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java 1229389
bq. trunk/core/src/main/java/org/apache/oozie/util/DateUtils.java 1229389
bq. trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java 1229389
bq. trunk/core/src/test/java/org/apache/oozie/coord/TestCoordUtils.java PRE-CREATION
bq. trunk/docs/src/site/twiki/DG_CoordinatorRerun.twiki 1229389
bq.
bq. Diff: https://reviews.apache.org/r/3441/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Tested against current test cases
bq. Test cases for CoordUtils added
bq. Ran the coordinator rerun example
bq.
bq.
bq. Thanks,
bq.
bq. Virag
bq.
bq.
> Coordinator rerun fails due to NPE in some cases
> ------------------------------------------------
>
> Key: OOZIE-651
> URL: https://issues.apache.org/jira/browse/OOZIE-651
> Project: Oozie
> Issue Type: Bug
> Reporter: Virag Kothari
>
> CoordinatorActionInfo coordInfo = coordEngine.reRun(jobId, rerunType, scope, Boolean.valueOf(refresh),
> Boolean.valueOf(noCleanup));
> coordActions = coordInfo.getCoordActions();
> The Coordinator rerun command requires to acquire the lock before it executes. If it cant get the lock, then it is queued. In this case the return value, the coordInfo, is null. Trying to access the coordInfo causes NPE in such a case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-651) Coordinator rerun fails due to NPE
in some cases
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184695#comment-13184695 ]
jiraposter@reviews.apache.org commented on OOZIE-651:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3441/#review4325
-----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java
<https://reviews.apache.org/r/3441/#comment9732>
what if a null coordActions is returned. you may end up with NPE
trunk/core/src/main/java/org/apache/oozie/coord/CoordUtils.java
<https://reviews.apache.org/r/3441/#comment9733>
I am assuming this is just copy and paste from the rerunXCommand
looks straightforward. few comments and questions
- Mohamed
On 2012-01-10 02:05:54, Virag Kothari wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3441/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-01-10 02:05:54)
bq.
bq.
bq. Review request for oozie, Mohammad Islam and Angelo K. Huang.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. https://issues.apache.org/jira/browse/OOZIE-651
bq.
bq.
bq. This addresses bug OOZIE-651.
bq. https://issues.apache.org/jira/browse/OOZIE-651
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/core/src/main/java/org/apache/oozie/LocalOozieClientCoord.java 1229389
bq. trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1229389
bq. trunk/core/src/main/java/org/apache/oozie/coord/CoordUtils.java 1229389
bq. trunk/core/src/main/java/org/apache/oozie/servlet/JobServlet.java 1229389
bq. trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1229389
bq. trunk/core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java 1229389
bq. trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java 1229389
bq. trunk/core/src/test/java/org/apache/oozie/coord/TestCoordUtils.java PRE-CREATION
bq. trunk/docs/src/site/twiki/DG_CoordinatorRerun.twiki 1229389
bq.
bq. Diff: https://reviews.apache.org/r/3441/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Tested against current test cases
bq. Test cases for CoordUtils added
bq. Ran the coordinator rerun example
bq.
bq.
bq. Thanks,
bq.
bq. Virag
bq.
bq.
> Coordinator rerun fails due to NPE in some cases
> ------------------------------------------------
>
> Key: OOZIE-651
> URL: https://issues.apache.org/jira/browse/OOZIE-651
> Project: Oozie
> Issue Type: Bug
> Reporter: Virag Kothari
>
> CoordinatorActionInfo coordInfo = coordEngine.reRun(jobId, rerunType, scope, Boolean.valueOf(refresh),
> Boolean.valueOf(noCleanup));
> coordActions = coordInfo.getCoordActions();
> The Coordinator rerun command requires to acquire the lock before it executes. If it cant get the lock, then it is queued. In this case the return value, the coordInfo, is null. Trying to access the coordInfo causes NPE in such a case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-651) Coordinator rerun fails due to NPE
in some cases
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185354#comment-13185354 ]
jiraposter@reviews.apache.org commented on OOZIE-651:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3441/
-----------------------------------------------------------
(Updated 2012-01-13 00:21:17.561232)
Review request for oozie, Mohammad Islam and Angelo K. Huang.
Changes
-------
Updated based on reviewer's feedback
Summary
-------
https://issues.apache.org/jira/browse/OOZIE-651
This addresses bug OOZIE-651.
https://issues.apache.org/jira/browse/OOZIE-651
Diffs (updated)
-----
trunk/core/src/main/java/org/apache/oozie/LocalOozieClientCoord.java 1229389
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1229389
trunk/core/src/main/java/org/apache/oozie/coord/CoordUtils.java 1229389
trunk/core/src/main/java/org/apache/oozie/servlet/JobServlet.java 1229389
trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1229389
trunk/core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java 1229389
trunk/core/src/main/java/org/apache/oozie/util/DateUtils.java 1229389
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java 1229389
trunk/core/src/test/java/org/apache/oozie/coord/TestCoordUtils.java PRE-CREATION
trunk/docs/src/site/twiki/DG_CoordinatorRerun.twiki 1229389
Diff: https://reviews.apache.org/r/3441/diff
Testing
-------
Tested against current test cases
Test cases for CoordUtils added
Ran the coordinator rerun example
Thanks,
Virag
> Coordinator rerun fails due to NPE in some cases
> ------------------------------------------------
>
> Key: OOZIE-651
> URL: https://issues.apache.org/jira/browse/OOZIE-651
> Project: Oozie
> Issue Type: Bug
> Reporter: Virag Kothari
>
> CoordinatorActionInfo coordInfo = coordEngine.reRun(jobId, rerunType, scope, Boolean.valueOf(refresh),
> Boolean.valueOf(noCleanup));
> coordActions = coordInfo.getCoordActions();
> The Coordinator rerun command requires to acquire the lock before it executes. If it cant get the lock, then it is queued. In this case the return value, the coordInfo, is null. Trying to access the coordInfo causes NPE in such a case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-651) Coordinator rerun fails due to NPE
in some cases
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183010#comment-13183010 ]
jiraposter@reviews.apache.org commented on OOZIE-651:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3441/
-----------------------------------------------------------
Review request for oozie, Mohammad Islam and Angelo K. Huang.
Summary
-------
https://issues.apache.org/jira/browse/OOZIE-651
This addresses bug OOZIE-651.
https://issues.apache.org/jira/browse/OOZIE-651
Diffs
-----
trunk/core/src/main/java/org/apache/oozie/LocalOozieClientCoord.java 1229389
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1229389
trunk/core/src/main/java/org/apache/oozie/coord/CoordUtils.java 1229389
trunk/core/src/main/java/org/apache/oozie/servlet/JobServlet.java 1229389
trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1229389
trunk/core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java 1229389
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java 1229389
trunk/core/src/test/java/org/apache/oozie/coord/TestCoordUtils.java PRE-CREATION
trunk/docs/src/site/twiki/DG_CoordinatorRerun.twiki 1229389
Diff: https://reviews.apache.org/r/3441/diff
Testing
-------
Tested against current test cases
Test cases for CoordUtils added
Ran the coordinator rerun example
Thanks,
Virag
> Coordinator rerun fails due to NPE in some cases
> ------------------------------------------------
>
> Key: OOZIE-651
> URL: https://issues.apache.org/jira/browse/OOZIE-651
> Project: Oozie
> Issue Type: Bug
> Reporter: Virag Kothari
>
> CoordinatorActionInfo coordInfo = coordEngine.reRun(jobId, rerunType, scope, Boolean.valueOf(refresh),
> Boolean.valueOf(noCleanup));
> coordActions = coordInfo.getCoordActions();
> The Coordinator rerun command requires to acquire the lock before it executes. If it cant get the lock, then it is queued. In this case the return value, the coordInfo, is null. Trying to access the coordInfo causes NPE in such a case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-651) Coordinator rerun fails due to NPE
in some cases
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183391#comment-13183391 ]
jiraposter@reviews.apache.org commented on OOZIE-651:
-----------------------------------------------------
bq. On 2012-01-10 03:23:10, Mohamed Battisha wrote:
bq. > any reasons for moving the list methods from the CoordRerunXCommand to the CoordUtility
bq. > it seems to be very related to the rerun command
These methods are being used by rerun command but very similar list methods also exist for retrieving logs for date and action range. So already there is some repetition of these functions. As they are generic methods for parsing date and action ranges, have moved them to the utility class.
- Virag
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3441/#review4290
-----------------------------------------------------------
On 2012-01-10 02:05:54, Virag Kothari wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3441/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-01-10 02:05:54)
bq.
bq.
bq. Review request for oozie, Mohammad Islam and Angelo K. Huang.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. https://issues.apache.org/jira/browse/OOZIE-651
bq.
bq.
bq. This addresses bug OOZIE-651.
bq. https://issues.apache.org/jira/browse/OOZIE-651
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/core/src/main/java/org/apache/oozie/LocalOozieClientCoord.java 1229389
bq. trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1229389
bq. trunk/core/src/main/java/org/apache/oozie/coord/CoordUtils.java 1229389
bq. trunk/core/src/main/java/org/apache/oozie/servlet/JobServlet.java 1229389
bq. trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1229389
bq. trunk/core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java 1229389
bq. trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java 1229389
bq. trunk/core/src/test/java/org/apache/oozie/coord/TestCoordUtils.java PRE-CREATION
bq. trunk/docs/src/site/twiki/DG_CoordinatorRerun.twiki 1229389
bq.
bq. Diff: https://reviews.apache.org/r/3441/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Tested against current test cases
bq. Test cases for CoordUtils added
bq. Ran the coordinator rerun example
bq.
bq.
bq. Thanks,
bq.
bq. Virag
bq.
bq.
> Coordinator rerun fails due to NPE in some cases
> ------------------------------------------------
>
> Key: OOZIE-651
> URL: https://issues.apache.org/jira/browse/OOZIE-651
> Project: Oozie
> Issue Type: Bug
> Reporter: Virag Kothari
>
> CoordinatorActionInfo coordInfo = coordEngine.reRun(jobId, rerunType, scope, Boolean.valueOf(refresh),
> Boolean.valueOf(noCleanup));
> coordActions = coordInfo.getCoordActions();
> The Coordinator rerun command requires to acquire the lock before it executes. If it cant get the lock, then it is queued. In this case the return value, the coordInfo, is null. Trying to access the coordInfo causes NPE in such a case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-651) Coordinator rerun fails due to NPE
in some cases
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185372#comment-13185372 ]
jiraposter@reviews.apache.org commented on OOZIE-651:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3441/#review4348
-----------------------------------------------------------
Ship it!
looks good
- Mohamed
On 2012-01-13 00:21:17, Virag Kothari wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3441/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-01-13 00:21:17)
bq.
bq.
bq. Review request for oozie, Mohammad Islam and Angelo K. Huang.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. https://issues.apache.org/jira/browse/OOZIE-651
bq.
bq.
bq. This addresses bug OOZIE-651.
bq. https://issues.apache.org/jira/browse/OOZIE-651
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/core/src/main/java/org/apache/oozie/LocalOozieClientCoord.java 1229389
bq. trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1229389
bq. trunk/core/src/main/java/org/apache/oozie/coord/CoordUtils.java 1229389
bq. trunk/core/src/main/java/org/apache/oozie/servlet/JobServlet.java 1229389
bq. trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1229389
bq. trunk/core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java 1229389
bq. trunk/core/src/main/java/org/apache/oozie/util/DateUtils.java 1229389
bq. trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java 1229389
bq. trunk/core/src/test/java/org/apache/oozie/coord/TestCoordUtils.java PRE-CREATION
bq. trunk/docs/src/site/twiki/DG_CoordinatorRerun.twiki 1229389
bq.
bq. Diff: https://reviews.apache.org/r/3441/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Tested against current test cases
bq. Test cases for CoordUtils added
bq. Ran the coordinator rerun example
bq.
bq.
bq. Thanks,
bq.
bq. Virag
bq.
bq.
> Coordinator rerun fails due to NPE in some cases
> ------------------------------------------------
>
> Key: OOZIE-651
> URL: https://issues.apache.org/jira/browse/OOZIE-651
> Project: Oozie
> Issue Type: Bug
> Reporter: Virag Kothari
>
> CoordinatorActionInfo coordInfo = coordEngine.reRun(jobId, rerunType, scope, Boolean.valueOf(refresh),
> Boolean.valueOf(noCleanup));
> coordActions = coordInfo.getCoordActions();
> The Coordinator rerun command requires to acquire the lock before it executes. If it cant get the lock, then it is queued. In this case the return value, the coordInfo, is null. Trying to access the coordInfo causes NPE in such a case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-651) Coordinator rerun fails due to NPE
in some cases
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184748#comment-13184748 ]
jiraposter@reviews.apache.org commented on OOZIE-651:
-----------------------------------------------------
bq. On 2012-01-12 03:18:42, Mohamed Battisha wrote:
bq. > trunk/core/src/main/java/org/apache/oozie/coord/CoordUtils.java, line 65
bq. > <https://reviews.apache.org/r/3441/diff/1/?file=67422#file67422line65>
bq. >
bq. > I am assuming this is just copy and paste from the rerunXCommand
getCoordActionsFromIds() is copy and paste, getCoordActionsFromDates() has been refactored a bit to use logic from CoordActionsInDateRange class.
bq. On 2012-01-12 03:18:42, Mohamed Battisha wrote:
bq. > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java, line 460
bq. > <https://reviews.apache.org/r/3441/diff/1/?file=67421#file67421line460>
bq. >
bq. > what if a null coordActions is returned. you may end up with NPE
Nope.. ParamChecker.null() has been added in the next function accessing coordActions
- Virag
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3441/#review4325
-----------------------------------------------------------
On 2012-01-10 02:05:54, Virag Kothari wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3441/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-01-10 02:05:54)
bq.
bq.
bq. Review request for oozie, Mohammad Islam and Angelo K. Huang.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. https://issues.apache.org/jira/browse/OOZIE-651
bq.
bq.
bq. This addresses bug OOZIE-651.
bq. https://issues.apache.org/jira/browse/OOZIE-651
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/core/src/main/java/org/apache/oozie/LocalOozieClientCoord.java 1229389
bq. trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1229389
bq. trunk/core/src/main/java/org/apache/oozie/coord/CoordUtils.java 1229389
bq. trunk/core/src/main/java/org/apache/oozie/servlet/JobServlet.java 1229389
bq. trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1229389
bq. trunk/core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java 1229389
bq. trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java 1229389
bq. trunk/core/src/test/java/org/apache/oozie/coord/TestCoordUtils.java PRE-CREATION
bq. trunk/docs/src/site/twiki/DG_CoordinatorRerun.twiki 1229389
bq.
bq. Diff: https://reviews.apache.org/r/3441/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Tested against current test cases
bq. Test cases for CoordUtils added
bq. Ran the coordinator rerun example
bq.
bq.
bq. Thanks,
bq.
bq. Virag
bq.
bq.
> Coordinator rerun fails due to NPE in some cases
> ------------------------------------------------
>
> Key: OOZIE-651
> URL: https://issues.apache.org/jira/browse/OOZIE-651
> Project: Oozie
> Issue Type: Bug
> Reporter: Virag Kothari
>
> CoordinatorActionInfo coordInfo = coordEngine.reRun(jobId, rerunType, scope, Boolean.valueOf(refresh),
> Boolean.valueOf(noCleanup));
> coordActions = coordInfo.getCoordActions();
> The Coordinator rerun command requires to acquire the lock before it executes. If it cant get the lock, then it is queued. In this case the return value, the coordInfo, is null. Trying to access the coordInfo causes NPE in such a case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OOZIE-651) Coordinator rerun fails due to NPE in
some cases
Posted by "Virag Kothari (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Virag Kothari updated OOZIE-651:
--------------------------------
For the patch committed in trunk with this JIRA ID (also available under the same JIRA ID in Apache ReviewBoard system), I grant license to ASF for inclusion in ASF works (as per the Apache License ยง5)
> Coordinator rerun fails due to NPE in some cases
> ------------------------------------------------
>
> Key: OOZIE-651
> URL: https://issues.apache.org/jira/browse/OOZIE-651
> Project: Oozie
> Issue Type: Bug
> Reporter: Virag Kothari
> Assignee: Virag Kothari
> Fix For: 3.2.0
>
>
> CoordinatorActionInfo coordInfo = coordEngine.reRun(jobId, rerunType, scope, Boolean.valueOf(refresh),
> Boolean.valueOf(noCleanup));
> coordActions = coordInfo.getCoordActions();
> The Coordinator rerun command requires to acquire the lock before it executes. If it cant get the lock, then it is queued. In this case the return value, the coordInfo, is null. Trying to access the coordInfo causes NPE in such a case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (OOZIE-651) Coordinator rerun fails due to NPE in
some cases
Posted by "Virag Kothari (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Virag Kothari resolved OOZIE-651.
---------------------------------
Resolution: Fixed
> Coordinator rerun fails due to NPE in some cases
> ------------------------------------------------
>
> Key: OOZIE-651
> URL: https://issues.apache.org/jira/browse/OOZIE-651
> Project: Oozie
> Issue Type: Bug
> Reporter: Virag Kothari
>
> CoordinatorActionInfo coordInfo = coordEngine.reRun(jobId, rerunType, scope, Boolean.valueOf(refresh),
> Boolean.valueOf(noCleanup));
> coordActions = coordInfo.getCoordActions();
> The Coordinator rerun command requires to acquire the lock before it executes. If it cant get the lock, then it is queued. In this case the return value, the coordInfo, is null. Trying to access the coordInfo causes NPE in such a case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-651) Coordinator rerun fails due to NPE
in some cases
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185324#comment-13185324 ]
jiraposter@reviews.apache.org commented on OOZIE-651:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3441/#review4337
-----------------------------------------------------------
sounds good, minor comments
trunk/core/src/main/java/org/apache/oozie/coord/CoordUtils.java
<https://reviews.apache.org/r/3441/#comment9767>
it will be better if you check for the validity of the date and throw an exception if it is not valid, instead of catching a generic exception
trunk/core/src/main/java/org/apache/oozie/coord/CoordUtils.java
<https://reviews.apache.org/r/3441/#comment9772>
check for null before adding to the set
trunk/core/src/main/java/org/apache/oozie/coord/CoordUtils.java
<https://reviews.apache.org/r/3441/#comment9773>
catching specific exception will be better
trunk/core/src/main/java/org/apache/oozie/coord/CoordUtils.java
<https://reviews.apache.org/r/3441/#comment9774>
you may specify what is wrong here ..
it should be greater than 2
trunk/core/src/main/java/org/apache/oozie/coord/CoordUtils.java
<https://reviews.apache.org/r/3441/#comment9775>
specify what is wrong will be easy to debug
trunk/core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java
<https://reviews.apache.org/r/3441/#comment9770>
catching the specific exception would be better
- Mohamed
On 2012-01-10 02:05:54, Virag Kothari wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3441/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-01-10 02:05:54)
bq.
bq.
bq. Review request for oozie, Mohammad Islam and Angelo K. Huang.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. https://issues.apache.org/jira/browse/OOZIE-651
bq.
bq.
bq. This addresses bug OOZIE-651.
bq. https://issues.apache.org/jira/browse/OOZIE-651
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/core/src/main/java/org/apache/oozie/LocalOozieClientCoord.java 1229389
bq. trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1229389
bq. trunk/core/src/main/java/org/apache/oozie/coord/CoordUtils.java 1229389
bq. trunk/core/src/main/java/org/apache/oozie/servlet/JobServlet.java 1229389
bq. trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1229389
bq. trunk/core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java 1229389
bq. trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java 1229389
bq. trunk/core/src/test/java/org/apache/oozie/coord/TestCoordUtils.java PRE-CREATION
bq. trunk/docs/src/site/twiki/DG_CoordinatorRerun.twiki 1229389
bq.
bq. Diff: https://reviews.apache.org/r/3441/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Tested against current test cases
bq. Test cases for CoordUtils added
bq. Ran the coordinator rerun example
bq.
bq.
bq. Thanks,
bq.
bq. Virag
bq.
bq.
> Coordinator rerun fails due to NPE in some cases
> ------------------------------------------------
>
> Key: OOZIE-651
> URL: https://issues.apache.org/jira/browse/OOZIE-651
> Project: Oozie
> Issue Type: Bug
> Reporter: Virag Kothari
>
> CoordinatorActionInfo coordInfo = coordEngine.reRun(jobId, rerunType, scope, Boolean.valueOf(refresh),
> Boolean.valueOf(noCleanup));
> coordActions = coordInfo.getCoordActions();
> The Coordinator rerun command requires to acquire the lock before it executes. If it cant get the lock, then it is queued. In this case the return value, the coordInfo, is null. Trying to access the coordInfo causes NPE in such a case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OOZIE-651) Coordinator rerun fails due to NPE in
some cases
Posted by "Alejandro Abdelnur (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alejandro Abdelnur updated OOZIE-651:
-------------------------------------
Fix Version/s: 3.2.0
> Coordinator rerun fails due to NPE in some cases
> ------------------------------------------------
>
> Key: OOZIE-651
> URL: https://issues.apache.org/jira/browse/OOZIE-651
> Project: Oozie
> Issue Type: Bug
> Reporter: Virag Kothari
> Fix For: 3.2.0
>
>
> CoordinatorActionInfo coordInfo = coordEngine.reRun(jobId, rerunType, scope, Boolean.valueOf(refresh),
> Boolean.valueOf(noCleanup));
> coordActions = coordInfo.getCoordActions();
> The Coordinator rerun command requires to acquire the lock before it executes. If it cant get the lock, then it is queued. In this case the return value, the coordInfo, is null. Trying to access the coordInfo causes NPE in such a case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-651) Coordinator rerun fails due to NPE
in some cases
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183048#comment-13183048 ]
jiraposter@reviews.apache.org commented on OOZIE-651:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3441/#review4290
-----------------------------------------------------------
any reasons for moving the list methods from the CoordRerunXCommand to the CoordUtility
it seems to be very related to the rerun command
- Mohamed
On 2012-01-10 02:05:54, Virag Kothari wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3441/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-01-10 02:05:54)
bq.
bq.
bq. Review request for oozie, Mohammad Islam and Angelo K. Huang.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. https://issues.apache.org/jira/browse/OOZIE-651
bq.
bq.
bq. This addresses bug OOZIE-651.
bq. https://issues.apache.org/jira/browse/OOZIE-651
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/core/src/main/java/org/apache/oozie/LocalOozieClientCoord.java 1229389
bq. trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1229389
bq. trunk/core/src/main/java/org/apache/oozie/coord/CoordUtils.java 1229389
bq. trunk/core/src/main/java/org/apache/oozie/servlet/JobServlet.java 1229389
bq. trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1229389
bq. trunk/core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java 1229389
bq. trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java 1229389
bq. trunk/core/src/test/java/org/apache/oozie/coord/TestCoordUtils.java PRE-CREATION
bq. trunk/docs/src/site/twiki/DG_CoordinatorRerun.twiki 1229389
bq.
bq. Diff: https://reviews.apache.org/r/3441/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Tested against current test cases
bq. Test cases for CoordUtils added
bq. Ran the coordinator rerun example
bq.
bq.
bq. Thanks,
bq.
bq. Virag
bq.
bq.
> Coordinator rerun fails due to NPE in some cases
> ------------------------------------------------
>
> Key: OOZIE-651
> URL: https://issues.apache.org/jira/browse/OOZIE-651
> Project: Oozie
> Issue Type: Bug
> Reporter: Virag Kothari
>
> CoordinatorActionInfo coordInfo = coordEngine.reRun(jobId, rerunType, scope, Boolean.valueOf(refresh),
> Boolean.valueOf(noCleanup));
> coordActions = coordInfo.getCoordActions();
> The Coordinator rerun command requires to acquire the lock before it executes. If it cant get the lock, then it is queued. In this case the return value, the coordInfo, is null. Trying to access the coordInfo causes NPE in such a case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira