You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2021/04/17 11:12:51 UTC

[GitHub] [samza] perkss opened a new pull request #1492: SAMZA-398: Remove force NONE compression for changelog topic producer

perkss opened a new pull request #1492:
URL: https://github.com/apache/samza/pull/1492


   Issues: KafkaSystemProducer has enforced compression of `NONE` for topics with the name `changelog`. Clients of Samza using topics named changelog are forced to have no compression. This was due to a bug in a very old Kafka version. This JIRA was raised to remove this in 2014 for `0.9.0.0` Kafka. We are now at `2.3.1`.
   
   Tests: Existing Tests. Checked running locally to ensure that the config remains the same. Integration tests now have `snappy` style compression. 
   API Changes: None
   Upgrade Instructions: None
   Usage Instructions: None


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [samza] nickpan47 commented on pull request #1492: SAMZA-398: Remove force NONE compression for changelog topic producer

Posted by GitBox <gi...@apache.org>.

nickpan47 commented on pull request #1492:
URL: https://github.com/apache/samza/pull/1492#issuecomment-843701869


   Thanks! Lgtm.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [samza] nickpan47 merged pull request #1492: SAMZA-398: Remove force NONE compression for changelog topic producer

Posted by GitBox <gi...@apache.org>.

nickpan47 merged pull request #1492:
URL: https://github.com/apache/samza/pull/1492


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [samza] perkss commented on pull request #1492: SAMZA-398: Remove force NONE compression for changelog topic producer

Posted by GitBox <gi...@apache.org>.

perkss commented on pull request #1492:
URL: https://github.com/apache/samza/pull/1492#issuecomment-840342732


   @mynameborat @nickpan47 @Sanil15 @kw2542 do you think you could check into this PR please? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [samza] nickpan47 edited a comment on pull request #1492: SAMZA-398: Remove force NONE compression for changelog topic producer

Posted by GitBox <gi...@apache.org>.

nickpan47 edited a comment on pull request #1492:
URL: https://github.com/apache/samza/pull/1492#issuecomment-843701869


   Thanks! Lgtm. @prateekm for another fresh pair of eyes on the potential changes on the changelog topic usage w/ the recent state store remote backup PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org