You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2018/07/02 14:09:21 UTC

[GitHub] wujimin commented on a change in pull request #782: [SCB-703] Fix deserialization problem in invoking void operation in RPC style

wujimin commented on a change in pull request #782: [SCB-703] Fix deserialization problem in invoking void operation in RPC style
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/782#discussion_r199509668
 
 

 ##########
 File path: common/common-javassist/src/main/java/org/apache/servicecomb/common/javassist/CtType.java
 ##########
 @@ -65,7 +65,7 @@ public CtType(JavaType javaType) {
   }
 
   private void init(CtClass ctClass, boolean hasGenericTypes, String genericSignature) {
-    if (ctClass.isPrimitive()) {
+    if (ctClass.isPrimitive() && !"void".equals(ctClass.getName())) {
 
 Review comment:
   void.class.getName?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services