You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2021/04/06 11:05:18 UTC
[GitHub] [fineract] josemakara2 opened a new pull request #1684: Add client IDs for selfservice user in auth credentials (FINERACT-1340)
josemakara2 opened a new pull request #1684:
URL: https://github.com/apache/fineract/pull/1684
## Description
Details in Apache Fineract JIRA ticket FINERACT-1340
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] josemakara2 commented on pull request #1684: Add client IDs for selfservice user in auth credentials (FINERACT-1340)
Posted by GitBox <gi...@apache.org>.
josemakara2 commented on pull request #1684:
URL: https://github.com/apache/fineract/pull/1684#issuecomment-817298613
@ptuomola
If you could please have a look at this, FINERACT-1340, when you have a moment ?
Many thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] josemakara2 commented on pull request #1684: Add client IDs for selfservice user in auth credentials (FINERACT-1340)
Posted by GitBox <gi...@apache.org>.
josemakara2 commented on pull request #1684:
URL: https://github.com/apache/fineract/pull/1684#issuecomment-820362767
> My suggestion would be instead to pass a boolean flag (i.e. returnClientList) to call of authenticate() from SelfAuthenticationApiResource and use that to determine whether clients should be included in the response.
Thanks. I have added commit a94f353ba1a81c10a14b271bad27d328722b11c8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola merged pull request #1684: Add client IDs for selfservice user in auth credentials (FINERACT-1340)
Posted by GitBox <gi...@apache.org>.
ptuomola merged pull request #1684:
URL: https://github.com/apache/fineract/pull/1684
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on pull request #1684: Add client IDs for selfservice user in auth credentials (FINERACT-1340)
Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #1684:
URL: https://github.com/apache/fineract/pull/1684#issuecomment-817378805
Hi
The comment says "Below one won't return client IDs in JSON and will continue working as it has been
https://localhost:8443/fineract-provider/api/v1/authentication"
But after this change, it would seem that the client IDs are if the attribute user.isSelfServiceUser() is set.
Given that this is read from the database (m_app_user.is_self_service_user), doesn't this mean that if someone calls /v1/authentication for a user for whom m_app_user.is_self_service_user=1, the /v1/authentication will also return the clients? Which was not the intention.
My suggestion would be instead to pass a boolean flag (i.e. returnClientList) to call of authenticate() from SelfAuthenticationApiResource and use that to determine whether clients should be included in the response.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org