[GitHub] [cassandra] dcapwell commented on a change in pull request #780: Cannot replace_address /X because it doesn't exist in gossip

[GitBox <gi...@apache.org>]

dcapwell commented on a change in pull request #780:
URL: https://github.com/apache/cassandra/pull/780#discussion_r535765927



##########
File path: src/java/org/apache/cassandra/gms/Gossiper.java
##########
@@ -1779,16 +1831,17 @@ public void addSavedEndpoint(InetAddressAndPort ep)
         if (epState != null)
         {
             logger.debug("not replacing a previous epState for {}, but reusing it: {}", ep, epState);
-            epState.setHeartBeatState(new HeartBeatState(0));
+            epState.setHeartBeatState(HeartBeatState.empty());
         }
         else
         {
-            epState = new EndpointState(new HeartBeatState(0));
+            epState = new EndpointState(HeartBeatState.empty());
+            logger.info("Adding {} as there was no previous epState; new state is {}", ep, epState);
         }
 
         epState.markDead();
         endpointStateMap.put(ep, epState);
-        unreachableEndpoints.put(ep, System.nanoTime());
+        markDead(ep, epState);

Review comment:
       at this point in the startup no listeners exist, I was mostly thinking to avoid having the same logic multiple places.  I do see your point about logs as this could spam larger clusters; will refactor.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org