You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Mryange (via GitHub)" <gi...@apache.org> on 2023/05/28 03:28:52 UTC

[GitHub] [doris] Mryange opened a new pull request, #20144: [fix](executor) Fixed an error with cast as time.

Mryange opened a new pull request, #20144:
URL: https://github.com/apache/doris/pull/20144

   ## Proposed changes
   
   before
   ```
   mysql [(none)]>select cast("10:10:10" as time);
   +-------------------------------+
   | CAST('10:10:10' AS TIMEV2(0)) |
   +-------------------------------+
   | 00:00:00                      |
   +-------------------------------+
   ```
   after
   ```
   mysql [(none)]>select cast("10:10:10" as time);
   +-------------------------------+
   | CAST('10:10:10' AS TIMEV2(0)) |
   +-------------------------------+
   | 10:10:10                      |
   +-------------------------------+
   ```
   In the past, we supported this syntax.
   ```
   mysql [(none)]>select cast("2023:05:01 13:14:15" as time);
   +------------------------------------------+
   | CAST('2023:05:01 13:14:15' AS TIMEV2(0)) |
   +------------------------------------------+
   | 13:14:15                                 |
   +------------------------------------------+
   ```
   However, "10:10:10" is also a valid datetime.
   ```
   mysql [(none)]>select cast("10:10:10" as datetime);
   +-----------------------------------+
   | CAST('10:10:10' AS DATETIMEV2(0)) |
   +-----------------------------------+
   | 2010-10-10 00:00:00               |
   +-----------------------------------+
   ```
   
   So here, the order of parsing has been adjusted.
   
   <--Describe your changes.-->
   
   
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] yiguolei merged pull request #20144: [fix](executor) Fixed an error with cast as time.

Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #20144:
URL: https://github.com/apache/doris/pull/20144


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] Mryange commented on pull request #20144: [fix](executor) Fixed an error with cast as time.

Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #20144:
URL: https://github.com/apache/doris/pull/20144#issuecomment-1565840013

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #20144: [fix](executor) Fixed an error with cast as time.

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20144:
URL: https://github.com/apache/doris/pull/20144#issuecomment-1566408525

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #20144: [fix](executor) Fixed an error with cast as time.

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20144:
URL: https://github.com/apache/doris/pull/20144#issuecomment-1566408502

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #20144: [fix](executor) Fixed an error with cast as time.

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20144:
URL: https://github.com/apache/doris/pull/20144#issuecomment-1565840933

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org