You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "pan3793 (via GitHub)" <gi...@apache.org> on 2023/06/06 07:05:04 UTC
[GitHub] [incubator-celeborn] pan3793 opened a new pull request, #1547: [CELEBORN-637] Remove support for rss.* configuration alias
pan3793 opened a new pull request, #1547:
URL: https://github.com/apache/incubator-celeborn/pull/1547
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
Remove support for `rss.*` configuration alias
### Why are the changes needed?
The legacy `rss.*` configuration alias was added during Celeborn entering Apache Incubator, to simplify users' migration from RSS to Celeborn.
Lots of configuration changes happened after Celeborn 0.2, the `rss.*` configuration alias become less helpful, so remove it to clean up the code.
### Does this PR introduce _any_ user-facing change?
Yes, but it's expected.
### How was this patch tested?
Pass GA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on pull request #1547: [CELEBORN-637] Remove support for rss.* configuration alias
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #1547:
URL: https://github.com/apache/incubator-celeborn/pull/1547#issuecomment-1580946443
Merged to main/0.3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1547: [CELEBORN-637] Remove support for rss.* configuration alias
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1547:
URL: https://github.com/apache/incubator-celeborn/pull/1547#issuecomment-1578059716
## [Codecov](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1547?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#1547](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1547?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (7172f94) into [main](https://app.codecov.io/gh/apache/incubator-celeborn/commit/3c7d179e051dce1dc4cf3a559a6761eadeccd9a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (3c7d179) will **decrease** coverage by `0.61%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## main #1547 +/- ##
==========================================
- Coverage 46.21% 45.60% -0.61%
==========================================
Files 158 158
Lines 9958 9813 -145
Branches 967 966 -1
==========================================
- Hits 4601 4474 -127
+ Misses 5055 5041 -14
+ Partials 302 298 -4
```
| [Impacted Files](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1547?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...cala/org/apache/celeborn/common/CelebornConf.scala](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1547?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL0NlbGVib3JuQ29uZi5zY2FsYQ==) | `87.14% <0.00%> (-0.76%)` | :arrow_down: |
| [.../celeborn/common/internal/config/ConfigEntry.scala](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1547?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL2ludGVybmFsL2NvbmZpZy9Db25maWdFbnRyeS5zY2FsYQ==) | `78.90% <ø> (ø)` | |
| [...leborn/common/internal/config/ConfigProvider.scala](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1547?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL2ludGVybmFsL2NvbmZpZy9Db25maWdQcm92aWRlci5zY2FsYQ==) | `50.00% <0.00%> (ø)` | |
| [.../scala/org/apache/celeborn/common/util/Utils.scala](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1547?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL3V0aWwvVXRpbHMuc2NhbGE=) | `19.05% <0.00%> (-0.33%)` | :arrow_down: |
... and [2 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1547/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on pull request #1547: [CELEBORN-637] Remove support for rss.* configuration alias
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #1547:
URL: https://github.com/apache/incubator-celeborn/pull/1547#issuecomment-1580209191
BTW, the `rss.*` compatibility has never been documented.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 closed pull request #1547: [CELEBORN-637] Remove support for rss.* configuration alias
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 closed pull request #1547: [CELEBORN-637] Remove support for rss.* configuration alias
URL: https://github.com/apache/incubator-celeborn/pull/1547
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] AngersZhuuuu commented on pull request #1547: [CELEBORN-637] Remove support for rss.* configuration alias
Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on PR #1547:
URL: https://github.com/apache/incubator-celeborn/pull/1547#issuecomment-1580158073
Ok for me but we'd better update the migration doc. Also we better keep a mapping table for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on pull request #1547: [CELEBORN-637] Remove support for rss.* configuration alias
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #1547:
URL: https://github.com/apache/incubator-celeborn/pull/1547#issuecomment-1580102648
@waitinfuture @AngersZhuuuu any concerns?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on pull request #1547: [CELEBORN-637] Remove support for rss.* configuration alias
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #1547:
URL: https://github.com/apache/incubator-celeborn/pull/1547#issuecomment-1580206406
@AngersZhuuuu lots of breaking changes during 0.x phase, I don't think we can guarantee seamless upgrading can skip minor versions before 1.x, e.g. upgrade from 0.1.0 and 0.3.0 directly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org