You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Clint Morgan (JIRA)" <ji...@apache.org> on 2009/10/01 23:03:23 UTC

[jira] Created: (HBASE-1879) ReadOnly transactions generate WAL activity.

ReadOnly transactions generate WAL activity.
--------------------------------------------

                 Key: HBASE-1879
                 URL: https://issues.apache.org/jira/browse/HBASE-1879
             Project: Hadoop HBase
          Issue Type: Bug
    Affects Versions: 0.20.0
            Reporter: Clint Morgan
            Assignee: Clint Morgan
             Fix For: 0.20.1, 0.21.0


Currently we write a start entry in the WAL each time a transaction starts, and a commit/abort at the end of the transaction. This means read-only transactions unnecessarily generate two WAL entries per region.

Can avoid this by removing the start entry from the WAL (this is implicit in the first trx OP entry we see), and only writing commit/abort when the transaction has a write.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-1879) ReadOnly transactions generate WAL activity.

Posted by "Clint Morgan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Clint Morgan updated HBASE-1879:
--------------------------------

    Attachment: 1879.patch

This fixes it. All transactional tests pass.

> ReadOnly transactions generate WAL activity.
> --------------------------------------------
>
>                 Key: HBASE-1879
>                 URL: https://issues.apache.org/jira/browse/HBASE-1879
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.20.0
>            Reporter: Clint Morgan
>            Assignee: Clint Morgan
>             Fix For: 0.20.1, 0.21.0
>
>         Attachments: 1879.patch
>
>
> Currently we write a start entry in the WAL each time a transaction starts, and a commit/abort at the end of the transaction. This means read-only transactions unnecessarily generate two WAL entries per region.
> Can avoid this by removing the start entry from the WAL (this is implicit in the first trx OP entry we see), and only writing commit/abort when the transaction has a write.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HBASE-1879) ReadOnly transactions generate WAL activity.

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack resolved HBASE-1879.
--------------------------

    Resolution: Fixed

Resolving.  Committed second patch.

> ReadOnly transactions generate WAL activity.
> --------------------------------------------
>
>                 Key: HBASE-1879
>                 URL: https://issues.apache.org/jira/browse/HBASE-1879
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.20.0
>            Reporter: Clint Morgan
>            Assignee: Clint Morgan
>            Priority: Minor
>             Fix For: 0.20.1, 0.21.0
>
>         Attachments: 1879-v2.patch, 1879.patch
>
>
> Currently we write a start entry in the WAL each time a transaction starts, and a commit/abort at the end of the transaction. This means read-only transactions unnecessarily generate two WAL entries per region.
> Can avoid this by removing the start entry from the WAL (this is implicit in the first trx OP entry we see), and only writing commit/abort when the transaction has a write.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (HBASE-1879) ReadOnly transactions generate WAL activity.

Posted by "Clint Morgan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Clint Morgan reopened HBASE-1879:
---------------------------------


please apply v2 to branch and trunk

> ReadOnly transactions generate WAL activity.
> --------------------------------------------
>
>                 Key: HBASE-1879
>                 URL: https://issues.apache.org/jira/browse/HBASE-1879
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.20.0
>            Reporter: Clint Morgan
>            Assignee: Clint Morgan
>            Priority: Minor
>             Fix For: 0.20.1, 0.21.0
>
>         Attachments: 1879-v2.patch, 1879.patch
>
>
> Currently we write a start entry in the WAL each time a transaction starts, and a commit/abort at the end of the transaction. This means read-only transactions unnecessarily generate two WAL entries per region.
> Can avoid this by removing the start entry from the WAL (this is implicit in the first trx OP entry we see), and only writing commit/abort when the transaction has a write.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-1879) ReadOnly transactions generate WAL activity.

Posted by "Clint Morgan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Clint Morgan updated HBASE-1879:
--------------------------------

    Priority: Minor  (was: Major)

> ReadOnly transactions generate WAL activity.
> --------------------------------------------
>
>                 Key: HBASE-1879
>                 URL: https://issues.apache.org/jira/browse/HBASE-1879
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.20.0
>            Reporter: Clint Morgan
>            Assignee: Clint Morgan
>            Priority: Minor
>             Fix For: 0.20.1, 0.21.0
>
>         Attachments: 1879.patch
>
>
> Currently we write a start entry in the WAL each time a transaction starts, and a commit/abort at the end of the transaction. This means read-only transactions unnecessarily generate two WAL entries per region.
> Can avoid this by removing the start entry from the WAL (this is implicit in the first trx OP entry we see), and only writing commit/abort when the transaction has a write.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-1879) ReadOnly transactions generate WAL activity.

Posted by "Clint Morgan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Clint Morgan updated HBASE-1879:
--------------------------------

    Attachment: 1879-v2.patch

I missed a line. 

> ReadOnly transactions generate WAL activity.
> --------------------------------------------
>
>                 Key: HBASE-1879
>                 URL: https://issues.apache.org/jira/browse/HBASE-1879
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.20.0
>            Reporter: Clint Morgan
>            Assignee: Clint Morgan
>            Priority: Minor
>             Fix For: 0.20.1, 0.21.0
>
>         Attachments: 1879-v2.patch, 1879.patch
>
>
> Currently we write a start entry in the WAL each time a transaction starts, and a commit/abort at the end of the transaction. This means read-only transactions unnecessarily generate two WAL entries per region.
> Can avoid this by removing the start entry from the WAL (this is implicit in the first trx OP entry we see), and only writing commit/abort when the transaction has a write.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HBASE-1879) ReadOnly transactions generate WAL activity.

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack resolved HBASE-1879.
--------------------------

    Resolution: Fixed

Committed branch and trunk.  Thanks for patch Clint.

> ReadOnly transactions generate WAL activity.
> --------------------------------------------
>
>                 Key: HBASE-1879
>                 URL: https://issues.apache.org/jira/browse/HBASE-1879
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.20.0
>            Reporter: Clint Morgan
>            Assignee: Clint Morgan
>            Priority: Minor
>             Fix For: 0.20.1, 0.21.0
>
>         Attachments: 1879.patch
>
>
> Currently we write a start entry in the WAL each time a transaction starts, and a commit/abort at the end of the transaction. This means read-only transactions unnecessarily generate two WAL entries per region.
> Can avoid this by removing the start entry from the WAL (this is implicit in the first trx OP entry we see), and only writing commit/abort when the transaction has a write.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-1879) ReadOnly transactions generate WAL activity.

Posted by "stack (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-1879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12761805#action_12761805 ] 

stack commented on HBASE-1879:
------------------------------

Done.  Thanks for patch Clint.

> ReadOnly transactions generate WAL activity.
> --------------------------------------------
>
>                 Key: HBASE-1879
>                 URL: https://issues.apache.org/jira/browse/HBASE-1879
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.20.0
>            Reporter: Clint Morgan
>            Assignee: Clint Morgan
>            Priority: Minor
>             Fix For: 0.20.1, 0.21.0
>
>         Attachments: 1879-v2.patch, 1879.patch
>
>
> Currently we write a start entry in the WAL each time a transaction starts, and a commit/abort at the end of the transaction. This means read-only transactions unnecessarily generate two WAL entries per region.
> Can avoid this by removing the start entry from the WAL (this is implicit in the first trx OP entry we see), and only writing commit/abort when the transaction has a write.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.