You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2022/11/14 06:51:30 UTC
[GitHub] [kylin] liuzhao-lz opened a new pull request, #2017: KYLIN-5293 NLP occur when discard job
liuzhao-lz opened a new pull request, #2017:
URL: https://github.com/apache/kylin/pull/2017
## Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
## Branch to commit
- [ ] Branch **kylin3** for v2.x to v3.x
- [x] Branch **kylin4** for v4.x
- [ ] Branch **kylin5** for v5.x
## Types of changes
What types of changes does your code introduce to Kylin?
_Put an `x` in the boxes that apply_
- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [x] I have created an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail
- [x] Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
- [ ] Compiling and unit tests pass locally with my changes
- [x] I have added tests that prove my fix is effective or that my feature works
- [ ] I have added necessary documentation (if appropriate)
- [ ] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at user@kylin.apache.org or dev@kylin.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] liuzhao-lz commented on pull request #2017: KYLIN-5293 NLP occur when discard job
Posted by GitBox <gi...@apache.org>.
liuzhao-lz commented on PR #2017:
URL: https://github.com/apache/kylin/pull/2017#issuecomment-1315329562
@Mukvin Thanks for your suggestion, I will refine this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] Mukvin commented on a diff in pull request #2017: KYLIN-5293 NLP occur when discard job
Posted by GitBox <gi...@apache.org>.
Mukvin commented on code in PR #2017:
URL: https://github.com/apache/kylin/pull/2017#discussion_r1022241375
##########
kylin-spark-project/kylin-spark-engine/src/main/java/org/apache/kylin/engine/spark/job/NSparkCubingJob.java:
##########
@@ -158,4 +158,19 @@ public void cleanupAfterJobDiscard(String segmentName, String segmentIdentifier)
logger.warn("Delete resource file failed after job be discarded, due to", e);
}
}
+
+ public void cleanupJobTempAfterJobDiscard() {
+ PathManager.deleteJobTempPath(getConfig(), getParam(MetadataConstants.P_PROJECT_NAME),
+ getParam(MetadataConstants.P_JOB_ID));
+ }
+
+ public void cleanupSegmentAfterJobDiscard(String segmentName, String segmentIdentifier) {
+ try {
+ CubeManager cubeManager = CubeManager.getInstance(getConfig());
+ CubeInstance cube = cubeManager.getCube(getParam(MetadataConstants.P_CUBE_NAME));
+ PathManager.deleteSegmentParquetStoragePath(cube, segmentName, segmentIdentifier);
Review Comment:
How can I get the notice that segments were deleted success?
Adding a piece of extra log information may be good that the progress is in this place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] liuzhao-lz commented on pull request #2017: KYLIN-5293 NLP occur when discard job
Posted by GitBox <gi...@apache.org>.
liuzhao-lz commented on PR #2017:
URL: https://github.com/apache/kylin/pull/2017#issuecomment-1345881287
org.apache.kylin.engine.spark.metadata.cube.PathManager#deleteSegmentParquetStoragePath and
org.apache.kylin.engine.spark.metadata.cube.PathManager#deleteJobTempPath has delete log information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org