You are viewing a plain text version of this content. The canonical link for it is here.

Posted to hdfs-issues@hadoop.apache.org by "Joe Pallas (JIRA)" <ji...@apache.org> on 2015/01/27 18:22:35 UTC

[jira] [Updated] (HDFS-7681) Fix ReplicaInputStream constructor to take InputStreams

     [ https://issues.apache.org/jira/browse/HDFS-7681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Joe Pallas updated HDFS-7681:
-----------------------------
    Attachment: HDFS-7681.patch

Patch attached for review.  I don't think there's anything controversial here.  The cleanup code to satisfy findbugs is slightly ugly; if there's a way to make it nicer while preserving exception safety I'd welcome a suggestion.

> Fix ReplicaInputStream constructor to take InputStreams
> -------------------------------------------------------
>
>                 Key: HDFS-7681
>                 URL: https://issues.apache.org/jira/browse/HDFS-7681
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode
>    Affects Versions: 3.0.0
>            Reporter: Joe Pallas
>            Assignee: Joe Pallas
>         Attachments: HDFS-7681.patch
>
>
> As noted in HDFS-5194, the constructor for {{ReplicaInputStream}} takes {{FileDescriptor}} s that are immediately turned into {{InputStream}} s, while the callers already have {{FileInputStream}} s from which they extract {{FileDescriptor}} s.  This seems to have been done as part of a large set of changes to appease findbugs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)