You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/05/31 11:10:31 UTC
[GitHub] [beam] damccorm commented on a diff in pull request #17594: [BEAM-14446] Update some docs to point to GitHub issues
damccorm commented on code in PR #17594:
URL: https://github.com/apache/beam/pull/17594#discussion_r885506768
##########
website/www/site/content/en/contribute/committer-guide.md:
##########
@@ -101,8 +101,9 @@ squash, split, etc, the commits, so that the history is most useful:
* Favor commits that do just one thing. The commit is the smallest unit of easy
rollback; it is easy to roll back many commits, or a whole pull request, but
harder to roll back part of a commit.
-* Commit messages should tag JIRAs and be otherwise descriptive.
-It should later not be necessary to find a merge or first PR commit to find out what caused a change.
+* Commit messages should be descriptive. It should later not be necessary to find a
Review Comment:
Good idea - updated to this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org