You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2021/08/10 09:48:40 UTC

[GitHub] [servicecomb-kie] little-cui commented on a change in pull request #193: add value type: xml, and set labels required

little-cui commented on a change in pull request #193:
URL: https://github.com/apache/servicecomb-kie/pull/193#discussion_r685865845



##########
File path: pkg/model/db_schema.go
##########
@@ -44,8 +44,8 @@ type KVDoc struct {
 	CreateTime     int64  `json:"create_time,omitempty" bson:"create_time," yaml:"create_time,omitempty"`
 	UpdateTime     int64  `json:"update_time,omitempty" bson:"update_time," yaml:"update_time,omitempty"`
 
-	Labels map[string]string `json:"labels,omitempty" yaml:"labels,omitempty" validate:"max=6,dive,keys,labelK,endkeys,labelV"` //redundant
-	Domain string            `json:"domain,omitempty" yaml:"domain,omitempty" validate:"min=1,max=256,commonName"`              //redundant
+	Labels map[string]string `json:"labels,omitempty" yaml:"labels,omitempty" validate:"min=1,max=6,dive,keys,labelK,endkeys,labelV"` //redundant

Review comment:
       允许没有labels




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org