You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Gabriel39 (via GitHub)" <gi...@apache.org> on 2023/10/10 08:54:46 UTC
[PR] [coverage](test) Delete unused function to improve test coverage [doris]
Gabriel39 opened a new pull request, #25233:
URL: https://github.com/apache/doris/pull/25233
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [coverage](test) Delete unused function to improve test coverage [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #25233:
URL: https://github.com/apache/doris/pull/25233#issuecomment-1754768463
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [coverage](test) Delete unused function to improve test coverage [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #25233:
URL: https://github.com/apache/doris/pull/25233#issuecomment-1756595235
TeamCity be ut coverage result:
Function Coverage: 36.34% (8151/22431)
Line Coverage: 28.46% (65187/229030)
Region Coverage: 27.39% (33783/123348)
Branch Coverage: 24.06% (17214/71544)
Coverage Report: http://coverage.selectdb-in.cc/coverage/735865a4f6b46bc3a027e9140fa3435c9f6e6ad3_735865a4f6b46bc3a027e9140fa3435c9f6e6ad3/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [coverage](test) Delete unused function to improve test coverage [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #25233:
URL: https://github.com/apache/doris/pull/25233#issuecomment-1754850062
TeamCity be ut coverage result:
Function Coverage: 36.31% (8151/22447)
Line Coverage: 28.46% (65196/229087)
Region Coverage: 27.38% (33782/123381)
Branch Coverage: 24.06% (17215/71558)
Coverage Report: http://coverage.selectdb-in.cc/coverage/4b6d83c1f5b49743e4f7e55331be5e9b27173ba5_4b6d83c1f5b49743e4f7e55331be5e9b27173ba5/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [coverage](test) Delete unused function to improve test coverage [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #25233:
URL: https://github.com/apache/doris/pull/25233#issuecomment-1756723319
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [coverage](test) Delete unused function to improve test coverage [doris]
Posted by "Gabriel39 (via GitHub)" <gi...@apache.org>.
Gabriel39 commented on PR #25233:
URL: https://github.com/apache/doris/pull/25233#issuecomment-1755483828
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [coverage](test) Delete unused function to improve test coverage [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #25233:
URL: https://github.com/apache/doris/pull/25233#issuecomment-1755630727
TeamCity be ut coverage result:
Function Coverage: 36.34% (8151/22432)
Line Coverage: 28.46% (65195/229044)
Region Coverage: 27.39% (33787/123351)
Branch Coverage: 24.06% (17216/71546)
Coverage Report: http://coverage.selectdb-in.cc/coverage/f7062cceecef9e320407c7b9f9c4bbdfd7ca5e0a_f7062cceecef9e320407c7b9f9c4bbdfd7ca5e0a/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [coverage](test) Delete unused function to improve test coverage [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #25233:
URL: https://github.com/apache/doris/pull/25233#issuecomment-1756723342
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [coverage](test) Delete unused function to improve test coverage [doris]
Posted by "Gabriel39 (via GitHub)" <gi...@apache.org>.
Gabriel39 commented on PR #25233:
URL: https://github.com/apache/doris/pull/25233#issuecomment-1756556784
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [coverage](test) Delete unused function to improve test coverage [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #25233:
URL: https://github.com/apache/doris/pull/25233#issuecomment-1756615071
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.72 seconds
stream load tsv: 554 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 22 seconds loaded 2358488459 Bytes, about 102 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17162059429 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [coverage](test) Delete unused function to improve test coverage [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #25233:
URL: https://github.com/apache/doris/pull/25233#discussion_r1352586850
##########
be/src/runtime/runtime_state.h:
##########
@@ -356,10 +356,7 @@ class RuntimeState {
return _query_options.__isset.skip_delete_bitmap && _query_options.skip_delete_bitmap;
}
- bool enable_page_cache() const {
- return !config::disable_storage_page_cache &&
- (_query_options.__isset.enable_page_cache && _query_options.enable_page_cache);
- }
+ bool enable_page_cache() const;
Review Comment:
warning: function 'enable_page_cache' should be marked [[nodiscard]] [modernize-use-nodiscard]
```suggestion
[[nodiscard]] bool enable_page_cache() const;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [coverage](test) Delete unused function to improve test coverage [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #25233:
URL: https://github.com/apache/doris/pull/25233#discussion_r1353773036
##########
be/src/vec/exec/format/parquet/parquet_pred_cmp.h:
##########
@@ -20,9 +20,12 @@
#include <cstring>
#include <vector>
+#include "cctz/civil_time.h"
Review Comment:
warning: 'cctz/civil_time.h' file not found [clang-diagnostic-error]
```cpp
#include "cctz/civil_time.h"
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [coverage](test) Delete unused function to improve test coverage [doris]
Posted by "Gabriel39 (via GitHub)" <gi...@apache.org>.
Gabriel39 merged PR #25233:
URL: https://github.com/apache/doris/pull/25233
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [coverage](test) Delete unused function to improve test coverage [doris]
Posted by "Gabriel39 (via GitHub)" <gi...@apache.org>.
Gabriel39 commented on PR #25233:
URL: https://github.com/apache/doris/pull/25233#issuecomment-1754752634
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org