You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by wa...@apache.org on 2023/02/25 09:25:03 UTC
[echarts] branch fix/sunburst-label-formatter-types created (now 03e02ab0a)
This is an automated email from the ASF dual-hosted git repository.
wangzx pushed a change to branch fix/sunburst-label-formatter-types
in repository https://gitbox.apache.org/repos/asf/echarts.git
at 03e02ab0a fix(type): fix `treePathInfo` is missing in the type of sunburst label formatter callback.
This branch includes the following new commits:
new 03e02ab0a fix(type): fix `treePathInfo` is missing in the type of sunburst label formatter callback.
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[echarts] 01/01: fix(type): fix `treePathInfo` is missing in the type of sunburst label formatter callback.
Posted by wa...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
wangzx pushed a commit to branch fix/sunburst-label-formatter-types
in repository https://gitbox.apache.org/repos/asf/echarts.git
commit 03e02ab0a456594318289fe62da8a9c4ec76eb24
Author: plainheart <yh...@all-my-life.cn>
AuthorDate: Sat Feb 25 17:20:49 2023 +0800
fix(type): fix `treePathInfo` is missing in the type of sunburst label formatter callback.
---
src/chart/sunburst/SunburstSeries.ts | 2 +-
src/util/types.ts | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/chart/sunburst/SunburstSeries.ts b/src/chart/sunburst/SunburstSeries.ts
index 402de0110..6ba13c41d 100644
--- a/src/chart/sunburst/SunburstSeries.ts
+++ b/src/chart/sunburst/SunburstSeries.ts
@@ -50,7 +50,7 @@ interface SunburstItemStyleOption<TCbParams = never> extends ItemStyleOption<TCb
borderRadius?: (number | string)[] | number | string
}
-interface SunburstLabelOption extends Omit<SeriesLabelOption, 'rotate' | 'position'> {
+interface SunburstLabelOption extends Omit<SeriesLabelOption<SunburstDataParams>, 'rotate' | 'position'> {
rotate?: 'radial' | 'tangential' | number
minAngle?: number
silent?: boolean
diff --git a/src/util/types.ts b/src/util/types.ts
index 56c7b6983..533844612 100644
--- a/src/util/types.ts
+++ b/src/util/types.ts
@@ -1064,8 +1064,8 @@ export interface LabelOption extends TextCommonOption {
rich?: Dictionary<TextCommonOption>
}
-export interface SeriesLabelOption extends LabelOption {
- formatter?: string | LabelFormatterCallback<CallbackDataParams>
+export interface SeriesLabelOption<T extends CallbackDataParams = CallbackDataParams> extends LabelOption {
+ formatter?: string | LabelFormatterCallback<T>
}
/**
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org