[GitHub] anirudhacharya commented on a change in pull request #12485: [WIP] test_ImageRecordIter_seed_augmentation flaky test fix

[GitBox <gi...@apache.org>]

anirudhacharya commented on a change in pull request #12485: [WIP] test_ImageRecordIter_seed_augmentation flaky test fix
URL: https://github.com/apache/incubator-mxnet/pull/12485#discussion_r231707642
 
 

 ##########
 File path: src/io/image_iter_common.h
 ##########
 @@ -165,6 +167,8 @@ struct ImageRecParserParam : public dmlc::Parameter<ImageRecParserParam> {
         .describe("The data shuffle buffer size in MB. Only valid if shuffle is true.");
     DMLC_DECLARE_FIELD(shuffle_chunk_seed).set_default(0)
         .describe("The random seed for shuffling");
+    DMLC_DECLARE_FIELD(seed_aug).set_default(dmlc::optional<int>())
 
 Review comment:
   maybe I am missing something here, but the PR says it fixes a flaky test. 
   
   Are we adding this new field just to fix the flakiness of a particular test? Can you please share the root cause of the flakiness based on your investigations?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services