You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by bo...@apache.org on 2022/11/14 07:20:57 UTC
[pulsar] branch branch-2.9 updated: [Improve][Auth]Update authentication failed metrics report (#17787)
This is an automated email from the ASF dual-hosted git repository.
bogong pushed a commit to branch branch-2.9
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/branch-2.9 by this push:
new 3844a746b97 [Improve][Auth]Update authentication failed metrics report (#17787)
3844a746b97 is described below
commit 3844a746b979ab8cfcaba487ddc7dde6a9900649
Author: Guangning E <gu...@streamnative.io>
AuthorDate: Mon Sep 26 13:02:08 2022 +0800
[Improve][Auth]Update authentication failed metrics report (#17787)
(cherry picked from commit 5068800d1f235fe293adf21a8c6000b48a2a54ad)
---
.../pulsar/broker/authentication/AuthenticationProviderList.java | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationProviderList.java b/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationProviderList.java
index 9ec1c2eb706..fc86a995921 100644
--- a/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationProviderList.java
+++ b/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationProviderList.java
@@ -28,6 +28,7 @@ import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
import lombok.extern.slf4j.Slf4j;
import org.apache.pulsar.broker.ServiceConfiguration;
+import org.apache.pulsar.broker.authentication.metrics.AuthenticationMetrics;
import org.apache.pulsar.common.api.AuthData;
/**
@@ -58,8 +59,15 @@ public class AuthenticationProviderList implements AuthenticationProvider {
}
if (null == authenticationException) {
+ AuthenticationMetrics.authenticateFailure(
+ AuthenticationProviderList.class.getSimpleName(),
+ "authentication-provider-list", "Authentication required");
throw new AuthenticationException("Authentication required");
} else {
+ AuthenticationMetrics.authenticateFailure(AuthenticationProviderList.class.getSimpleName(),
+ "authentication-provider-list",
+ authenticationException.getMessage() != null
+ ? authenticationException.getMessage() : "Authentication required");
throw authenticationException;
}