You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benno Evers <be...@mesosphere.com> on 2019/06/07 14:56:02 UTC
Review Request 70810: Updated SSL docs with suggested runtime
configuration.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70810/
-----------------------------------------------------------
Review request for mesos, Alexander Rukletsov, Joseph Wu, and Till Toenshoff.
Bugs: MESOS-9791
https://issues.apache.org/jira/browse/MESOS-9791
Repository: mesos
Description
-------
Updated SSL docs with suggested runtime configuration.
Diffs
-----
docs/ssl.md ce5058896144aa7824986d40d996899d92cb7c1c
Diff: https://reviews.apache.org/r/70810/diff/1/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 70810: Updated SSL docs with suggested runtime
configuration.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70810/#review215752
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70810]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On June 7, 2019, 2:56 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70810/
> -----------------------------------------------------------
>
> (Updated June 7, 2019, 2:56 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Joseph Wu, and Till Toenshoff.
>
>
> Bugs: MESOS-9791
> https://issues.apache.org/jira/browse/MESOS-9791
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated SSL docs with suggested runtime configuration.
>
>
> Diffs
> -----
>
> docs/ssl.md ce5058896144aa7824986d40d996899d92cb7c1c
>
>
> Diff: https://reviews.apache.org/r/70810/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 70810: Updated SSL docs with suggested runtime
configuration.
Posted by Till Toenshoff via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70810/#review216011
-----------------------------------------------------------
Ship it!
Awesome - thanks!
- Till Toenshoff
On June 20, 2019, 5:32 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70810/
> -----------------------------------------------------------
>
> (Updated June 20, 2019, 5:32 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Joseph Wu, and Till Toenshoff.
>
>
> Bugs: MESOS-9791
> https://issues.apache.org/jira/browse/MESOS-9791
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated SSL docs with suggested runtime configuration.
>
>
> Diffs
> -----
>
> docs/ssl.md ce5058896144aa7824986d40d996899d92cb7c1c
>
>
> Diff: https://reviews.apache.org/r/70810/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 70810: Updated SSL docs with suggested runtime
configuration.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70810/
-----------------------------------------------------------
(Updated June 20, 2019, 5:32 p.m.)
Review request for mesos, Alexander Rukletsov, Joseph Wu, and Till Toenshoff.
Bugs: MESOS-9791
https://issues.apache.org/jira/browse/MESOS-9791
Repository: mesos
Description (updated)
-------
Updated SSL docs with suggested runtime configuration.
Diffs (updated)
-----
docs/ssl.md ce5058896144aa7824986d40d996899d92cb7c1c
Diff: https://reviews.apache.org/r/70810/diff/3/
Changes: https://reviews.apache.org/r/70810/diff/2-3/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 70810: Updated SSL docs with suggested runtime
configuration.
Posted by Benno Evers <be...@mesosphere.com>.
> On June 20, 2019, 12:49 p.m., Jan-Philip Gehrcke wrote:
> > docs/ssl.md
> > Lines 90 (patched)
> > <https://reviews.apache.org/r/70810/diff/2/?file=2151333#file2151333line90>
> >
> > Let's define "and contain the correct hostname", let's refer to the available algorithms.
I did that in the other review, since strictly speaking this commit does not yet contain the hostname validation option.
- Benno
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70810/#review215997
-----------------------------------------------------------
On June 20, 2019, 5:32 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70810/
> -----------------------------------------------------------
>
> (Updated June 20, 2019, 5:32 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Joseph Wu, and Till Toenshoff.
>
>
> Bugs: MESOS-9791
> https://issues.apache.org/jira/browse/MESOS-9791
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated SSL docs with suggested runtime configuration.
>
>
> Diffs
> -----
>
> docs/ssl.md ce5058896144aa7824986d40d996899d92cb7c1c
>
>
> Diff: https://reviews.apache.org/r/70810/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 70810: Updated SSL docs with suggested runtime
configuration.
Posted by Jan-Philip Gehrcke via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70810/#review215997
-----------------------------------------------------------
Fix it, then Ship it!
Great work. I have added a few minor comments and would appreciate consideration. Thanks!
docs/ssl.md
Lines 24 (patched)
<https://reviews.apache.org/r/70810/#comment302925>
Should we write TLS instead of SSL in new text sections?
docs/ssl.md
Lines 30 (patched)
<https://reviews.apache.org/r/70810/#comment302926>
... provides external clients ... with the ability ...
docs/ssl.md
Lines 33 (patched)
<https://reviews.apache.org/r/70810/#comment302927>
ensures
docs/ssl.md
Lines 37 (patched)
<https://reviews.apache.org/r/70810/#comment302928>
maybe WARNING instead of NOTE
docs/ssl.md
Lines 47 (patched)
<https://reviews.apache.org/r/70810/#comment302929>
if `LIBPROCESS_SSL_ENABLE_DOWNGRADE` is set to `false`
docs/ssl.md
Lines 88 (patched)
<https://reviews.apache.org/r/70810/#comment302923>
Let's make clear that the server is _required_ to present a certificate.
docs/ssl.md
Lines 90 (patched)
<https://reviews.apache.org/r/70810/#comment302922>
Let's define "and contain the correct hostname", let's refer to the available algorithms.
docs/ssl.md
Lines 99 (patched)
<https://reviews.apache.org/r/70810/#comment302924>
Let's maybe clarify "including tools hitting endpoints" (HTTP clients hitting HTTP endpoints?)
- Jan-Philip Gehrcke
On June 19, 2019, 2:31 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70810/
> -----------------------------------------------------------
>
> (Updated June 19, 2019, 2:31 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Joseph Wu, and Till Toenshoff.
>
>
> Bugs: MESOS-9791
> https://issues.apache.org/jira/browse/MESOS-9791
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated SSL docs to reflect the changes introduced in the previous commit and added a section with suggested runtime configuration intended for operators.
>
>
> Diffs
> -----
>
> docs/ssl.md ce5058896144aa7824986d40d996899d92cb7c1c
>
>
> Diff: https://reviews.apache.org/r/70810/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 70810: Updated SSL docs with suggested runtime
configuration.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70810/
-----------------------------------------------------------
(Updated June 19, 2019, 2:31 p.m.)
Review request for mesos, Alexander Rukletsov, Joseph Wu, and Till Toenshoff.
Bugs: MESOS-9791
https://issues.apache.org/jira/browse/MESOS-9791
Repository: mesos
Description (updated)
-------
Updated SSL docs to reflect the changes introduced in the previous commit and added a section with suggested runtime configuration intended for operators.
Diffs (updated)
-----
docs/ssl.md ce5058896144aa7824986d40d996899d92cb7c1c
Diff: https://reviews.apache.org/r/70810/diff/2/
Changes: https://reviews.apache.org/r/70810/diff/1-2/
Testing
-------
Thanks,
Benno Evers