You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/11/16 11:24:18 UTC

[GitHub] [skywalking-cli] kezhenxu94 opened a new pull request #129: Add cross platform build targets

kezhenxu94 opened a new pull request #129:
URL: https://github.com/apache/skywalking-cli/pull/129


   This is a prerequisite of https://github.com/apache/skywalking/pull/8015 as the OAP references the CLI Docker so the latter one has to provide for all architectures


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking-cli] kezhenxu94 commented on pull request #129: Add cross platform build targets

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #129:
URL: https://github.com/apache/skywalking-cli/pull/129#issuecomment-970206263


   > So, we have images for windows, linux and linux/arm64, right?
   
   Yes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking-cli] kezhenxu94 merged pull request #129: Add cross platform build targets

Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #129:
URL: https://github.com/apache/skywalking-cli/pull/129


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking-cli] codecov-commenter commented on pull request #129: Add cross platform build targets

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #129:
URL: https://github.com/apache/skywalking-cli/pull/129#issuecomment-970180799


   # [Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/129?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#129](https://codecov.io/gh/apache/skywalking-cli/pull/129?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0a2cc68) into [master](https://codecov.io/gh/apache/skywalking-cli/commit/45a5f9807126dc6ea9fe06e17e7aafbe212436d2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (45a5f98) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking-cli/pull/129/graphs/tree.svg?width=650&height=150&src=pr&token=oivudZDTNJ&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking-cli/pull/129?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master     #129   +/-   ##
   =======================================
     Coverage   27.47%   27.47%           
   =======================================
     Files          20       20           
     Lines         404      404           
   =======================================
     Hits          111      111           
     Misses        286      286           
     Partials        7        7           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/129?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/129?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [45a5f98...0a2cc68](https://codecov.io/gh/apache/skywalking-cli/pull/129?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking-cli] mis98zb commented on pull request #129: Add cross platform build targets

Posted by GitBox <gi...@apache.org>.
mis98zb commented on pull request #129:
URL: https://github.com/apache/skywalking-cli/pull/129#issuecomment-971142980


   👍👍👍
   
   btw, I'm not very clear with the code, but from command in makefie:
   ```makefile
   docker:
   	docker buildx create --use
   	docker buildx build $(PUSH) --platform linux/386,linux/amd64,linux/arm64 --build-arg VERSION=$(VERSION) . -t $(HUB)/$(APP_NAME):$(VERSION) -t $(HUB)/$(APP_NAME):latest
   ```
   It seems the windows platform is not included?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org