You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@guacamole.apache.org by "Michael Jumper (JIRA)" <ji...@apache.org> on 2017/11/26 05:14:00 UTC
[jira] [Comment Edited] (GUACAMOLE-363) Support Microsoft SQL
Server Authentication
[ https://issues.apache.org/jira/browse/GUACAMOLE-363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265912#comment-16265912 ]
Michael Jumper edited comment on GUACAMOLE-363 at 11/26/17 5:13 AM:
--------------------------------------------------------------------
While working on the database auth changes related to arbitrary storage of attributes from other extensions (necessary for GUACAMOLE-96), I noticed that some tables were missing indexes relative to the other schema implementations. Reorganizing/reformatting the SQL to match the existing MySQL and PostgreSQL schema scripts, I found:
* Indexes are missing for the various foreign keys (SQL Server, like PostgreSQL, requires that such indexes be created manually).
* {{ON DELETE CASCADE}} and {{ON DELETE SET NULL}} are not always possible due to SQL Server's lazy implementation of these, requiring manual implementation of those actions with triggers.
I believe I have things working, including the trigger implementations of missing {{ON DELETE}} actions, with things reformatted so that things are (hopefully) more easily compared between the different implementations of the same schema.
Will open a PR once INFRA-15505 (repository rename) is completed.
was (Author: mike.jumper):
While working on the database auth changes related arbitrary storage of attributes from other extensions (necessary for GUACAMOLE-96), I noticed that some tables were missing indexes relative to the other schema implementations. Reorganizing/reformatting the SQL to match the existing MySQL and PostgreSQL schema scripts, I found:
* Indexes are missing for the various foreign keys (SQL Server, like PostgreSQL, requires that such indexes be created manually).
* {{ON DELETE CASCADE}} and {{ON DELETE SET NULL}} are not always possible due to SQL Server's lazy implementation of these, requiring manual implementation of those actions with triggers.
I believe I have things working, including the trigger implementations of missing {{ON DELETE}} actions, with things reformatted so that things are (hopefully) more easily compared between the different implementations of the same schema.
Will open a PR once INFRA-15505 (repository rename) is completed.
> Support Microsoft SQL Server Authentication
> -------------------------------------------
>
> Key: GUACAMOLE-363
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-363
> Project: Guacamole
> Issue Type: Improvement
> Components: guacamole-auth-jdbc
> Affects Versions: 0.9.13-incubating
> Reporter: Nick Couchman
> Assignee: Nick Couchman
> Priority: Minor
> Fix For: 0.9.14
>
>
> Given recent focus on renewing Guacamole compatibility with Windows, having Microsoft SQL Server support seems like a good move. Also, SQL Server is now available on Linux, since (apparently) Microsoft <3 Linux, so this will provide SQL Server as a backend for those who want to run that.
> Pull Request coming in just a little while.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)