[GitHub] [trafficserver] ywkaras commented on a change in pull request #7553: Get rid of kruft LogObject copy constructor.

[GitBox <gi...@apache.org>]

ywkaras commented on a change in pull request #7553:
URL: https://github.com/apache/trafficserver/pull/7553#discussion_r582095321



##########
File path: proxy/logging/LogObject.h
##########
@@ -97,7 +97,6 @@ class LogObject : public RefCountObj
             const char *header, Log::RollingEnabledValues rolling_enabled, int flush_threads, int rolling_interval_sec = 0,
             int rolling_offset_hr = 0, int rolling_size_mb = 0, bool auto_created = false, int rolling_max_count = 0,
             int rolling_min_count = 0, bool reopen_after_rolling = false, int pipe_buffer_size = 0);
-  LogObject(LogObject &);

Review comment:
       These are already present:  https://github.com/apache/trafficserver/blob/e6291181b4eb6bc98b57fa1cd86ec07fd2d59928/proxy/logging/LogObject.h#L300
   Although they are private, which would make for a confusing error message I think.  So the defined copy constructor is especially krufty, it only applies to non-const source objects.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org