You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by "wilfred-s (via GitHub)" <gi...@apache.org> on 2023/04/17 16:19:30 UTC

[GitHub] [yunikorn-site] wilfred-s commented on a diff in pull request #286: [YUNIKORN-1527] Add website build to PR workflow

wilfred-s commented on code in PR #286:
URL: https://github.com/apache/yunikorn-site/pull/286#discussion_r1168980347


##########
.github/workflows/pre-commit.yml:
##########
@@ -30,3 +30,5 @@ jobs:
           fetch-depth: 2
       - name: Check license
         run: ./check_license.sh
+      - name: Build the site image
+        run: docker build -t yunikorn/yunikorn-website:2.0.0 . --build-arg NODE_VERSION=16.14

Review Comment:
   We should use the same construct for building as we do in the push build. We read the node version from the `.nvmrc` file. See the push flow lines 34 and 36 on the how and what.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org