You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gaston Kleiman <ga...@mesosphere.io> on 2017/10/18 17:00:02 UTC
Review Request 63116: Mesos UI: fixed use of undefined variable for
the pailer title.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63116/
-----------------------------------------------------------
Review request for mesos, Alexander Rojas and Benjamin Mahler.
Repository: mesos
Description
-------
This patch fixes the use of an undefined variable to generate the
pailer's window title in `pailer()`.
The title used for pailers that read agent files used to be: "path
(host:port)", it is now "path (agentId)".
Diffs
-----
src/webui/master/static/js/controllers.js fa0ad54cbcec7a3b0bea9e2b0dc70a4c3f41e822
Diff: https://reviews.apache.org/r/63116/diff/1/
Testing
-------
Thanks,
Gaston Kleiman
Re: Review Request 63116: Mesos UI: fixed use of undefined variable
for the pailer title.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63116/#review188548
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Mahler
On Oct. 18, 2017, 5 p.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63116/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2017, 5 p.m.)
>
>
> Review request for mesos, Alexander Rojas and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch fixes the use of an undefined variable to generate the
> pailer's window title in `pailer()`.
>
> The title used for pailers that read agent files used to be: "path
> (host:port)", it is now "path (agentId)".
>
>
> Diffs
> -----
>
> src/webui/master/static/js/controllers.js fa0ad54cbcec7a3b0bea9e2b0dc70a4c3f41e822
>
>
> Diff: https://reviews.apache.org/r/63116/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gaston Kleiman
>
>
Re: Review Request 63116: Mesos UI: fixed use of undefined variable
for the pailer title.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63116/#review188559
-----------------------------------------------------------
PASS: Mesos patch 63116 was successfully built and tested.
Reviews applied: `['63116']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63116
- Mesos Reviewbot Windows
On Oct. 18, 2017, 7 p.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63116/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2017, 7 p.m.)
>
>
> Review request for mesos, Alexander Rojas and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch fixes the use of an undefined variable to generate the
> pailer's window title in `pailer()`.
>
> The title used for pailers that read agent files used to be: "path
> (host:port)", it is now "path (agentId)".
>
>
> Diffs
> -----
>
> src/webui/master/static/js/controllers.js fa0ad54cbcec7a3b0bea9e2b0dc70a4c3f41e822
>
>
> Diff: https://reviews.apache.org/r/63116/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gaston Kleiman
>
>