You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "rusackas (via GitHub)" <gi...@apache.org> on 2026/09/07 23:14:45 UTC
[PR] fix(ci): use self-repository syntax for local actions in presto-hive workflow [superset]
rusackas opened a new pull request, #43975:
URL: https://github.com/apache/superset/pull/43975
### SUMMARY
`zizmor`'s `self-repository` audit flags `uses: ./...` references to in-repo composite actions because that workspace-relative form isn't recognized as a "pinned" reference and, unlike GitHub's dedicated self-repository syntax (`uses: $/...`), can be influenced by whatever a prior step has checked out into the workspace. This PR switches the local action references in `superset-python-presto-hive.yml` to the `$/...` form (generated via `zizmor --fix`).
Resolves code-scanning alert #2667 (and sibling `self-repository` alerts #2662, #2663, #2664, #2665, #2666, #2668, which point at the same file).
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A (workflow YAML only)
### TESTING INSTRUCTIONS
- `pre-commit run --files .github/workflows/superset-python-presto-hive.yml` passes (includes the `zizmor` hook)
- `zizmor .github/workflows/superset-python-presto-hive.yml` reports 0 `self-repository` findings after the change
- CI should trigger and run this workflow the same as before, since `$/...` and `./...` resolve to the same in-repo action content
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(ci): use self-repository syntax for local actions in presto-hive workflow [superset]
Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe commented on code in PR #43975:
URL: https://github.com/apache/superset/pull/43975#discussion_r3953505927
##########
.github/workflows/superset-python-presto-hive.yml:
##########
@@ -80,13 +80,13 @@ jobs:
persist-credentials: false
submodules: recursive
- name: Setup Python
- uses: ./.github/actions/setup-backend/
+ uses: $/.github/actions/setup-backend/
- name: Setup Postgres
- uses: ./.github/actions/cached-dependencies
+ uses: $/.github/actions/cached-dependencies
Review Comment:
These references now resolve `cached-dependencies` through the main repository tree, but that path is a submodule gitlink rather than a directory. The self-repository resolver cannot load its `action.yml` from the submodule, so both Presto/Hive jobs fail before tests start. Could these four references remain workspace-relative after the recursive checkout, while keeping `$/` for the two in-tree actions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(ci): use self-repository syntax for local actions in presto-hive workflow [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #43975:
URL: https://github.com/apache/superset/pull/43975
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(ci): use self-repository syntax for local actions in presto-hive workflow [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #43975:
URL: https://github.com/apache/superset/pull/43975#issuecomment-5576803883
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/43975?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 66.50%. Comparing base ([`1fb6b98`](https://app.codecov.io/gh/apache/superset/commit/1fb6b98941345a99b12240f482dcbd72caadd34e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`7eed44f`](https://app.codecov.io/gh/apache/superset/commit/7eed44fe0c194fb9e3d9a116c39a183093b937d3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
> :exclamation: There is a different number of reports uploaded between BASE (1fb6b98) and HEAD (7eed44f). Click for more details.
>
> <details><summary>HEAD has 20 uploads less than BASE</summary>
>
>| Flag | BASE (1fb6b98) | HEAD (7eed44f) |
>|------|------|------|
>|python|17|3|
>|sqlite|3|1|
>|postgres|3|1|
>|mysql|3|1|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #43975 +/- ##
===========================================
- Coverage 79.81% 66.50% -13.31%
===========================================
Files 2914 2914
Lines 170470 170470
Branches 39518 39518
===========================================
- Hits 136060 113379 -22681
- Misses 31888 54756 +22868
+ Partials 2522 2335 -187
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/43975/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hive](https://app.codecov.io/gh/apache/superset/pull/43975/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [mysql](https://app.codecov.io/gh/apache/superset/pull/43975/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.32% <ø> (ø)` | |
| [postgres](https://app.codecov.io/gh/apache/superset/pull/43975/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.34% <ø> (ø)` | |
| [presto](https://app.codecov.io/gh/apache/superset/pull/43975/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [python](https://app.codecov.io/gh/apache/superset/pull/43975/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.55% <ø> (-26.64%)` | :arrow_down: |
| [sqlite](https://app.codecov.io/gh/apache/superset/pull/43975/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.06% <ø> (ø)` | |
| [unit](https://app.codecov.io/gh/apache/superset/pull/43975/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/43975?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(ci): use self-repository syntax for local actions in presto-hive workflow [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #43975:
URL: https://github.com/apache/superset/pull/43975#issuecomment-5576560572
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(ci): use self-repository syntax for local actions in presto-hive workflow [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #43975:
URL: https://github.com/apache/superset/pull/43975#issuecomment-5577562468
<!-- Bito Reply -->
Yes, you can revert the `cached-dependencies` references to use workspace-relative paths (`./.github/actions/cached-dependencies`) while keeping the `$/` syntax for the two in-tree actions (`change-detector` and `setup-backend`). This approach allows the workflow to correctly resolve the actions located in the main repository tree, even when submodules are present, by distinguishing between the workspace root and the repository root.
**.github/workflows/superset-python-presto-hive.yml**
```
- uses: ./.github/actions/cached-dependencies
with:
run: setup-postgres
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(ci): use self-repository syntax for local actions in presto-hive workflow [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #43975:
URL: https://github.com/apache/superset/pull/43975#issuecomment-5594536871
**Bito Automatic Review Skipped – PR Already Merged**<br/><br/>Bito scheduled an automatic review for this pull request, but the review was skipped because this PR was merged before the review could be run.<br/>No action is needed if you didn't intend to review it. To get a review, you can type `/review` in a comment and save it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org