You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anindya Sinha <an...@apple.com> on 2017/04/17 23:14:20 UTC
Review Request 58485: Avoid a corruption while rescinding offers.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58485/
-----------------------------------------------------------
Review request for mesos, James Peach and Jiang Yan Xu.
Bugs: MESOS-7308
https://issues.apache.org/jira/browse/MESOS-7308
Repository: mesos
Description
-------
When a `DESTROY` is processed, we rescind all pending offers to which
persistent volumes have been offered. As soon as we rescind an offer,
the `Offer` object is freed; and hence, we should move on to the next
offer (even though there are multiple volumes being destroyed in
the same `ACCEPT` call).
Diffs
-----
src/master/master.cpp 0f4c64c6b102ef201779a331c96b5d78a98281ad
src/tests/persistent_volume_tests.cpp 3eb7afe3de8e72ffb6502dfe12ef37ccd4ca2125
Diff: https://reviews.apache.org/r/58485/diff/1/
Testing
-------
Tests passed.
Thanks,
Anindya Sinha
Re: Review Request 58485: Avoid a corruption while rescinding offers.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58485/#review172274
-----------------------------------------------------------
Fix it, then Ship it!
src/master/master.cpp
Lines 4334-4335 (patched)
<https://reviews.apache.org/r/58485/#comment245377>
s/can/should/ ?
Also move a little bit of the commit description here to justify this comment. Something like "This offer may contain other volumes to be destroyed but since we have already rescinded it, we should move on to the next offer."?
src/tests/persistent_volume_tests.cpp
Line 1084 (original), 1096 (patched)
<https://reviews.apache.org/r/58485/#comment245378>
s/volume/volumes/?
src/tests/persistent_volume_tests.cpp
Line 1154 (original), 1170 (patched)
<https://reviews.apache.org/r/58485/#comment245379>
s/offers/offer/?
- Jiang Yan Xu
On April 17, 2017, 4:14 p.m., Anindya Sinha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58485/
> -----------------------------------------------------------
>
> (Updated April 17, 2017, 4:14 p.m.)
>
>
> Review request for mesos, James Peach and Jiang Yan Xu.
>
>
> Bugs: MESOS-7308
> https://issues.apache.org/jira/browse/MESOS-7308
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When a `DESTROY` is processed, we rescind all pending offers to which
> persistent volumes have been offered. As soon as we rescind an offer,
> the `Offer` object is freed; and hence, we should move on to the next
> offer (even though there are multiple volumes being destroyed in
> the same `ACCEPT` call).
>
>
> Diffs
> -----
>
> src/master/master.cpp 0f4c64c6b102ef201779a331c96b5d78a98281ad
> src/tests/persistent_volume_tests.cpp 3eb7afe3de8e72ffb6502dfe12ef37ccd4ca2125
>
>
> Diff: https://reviews.apache.org/r/58485/diff/1/
>
>
> Testing
> -------
>
> Tests passed.
>
>
> Thanks,
>
> Anindya Sinha
>
>
Re: Review Request 58485: Avoid a corruption while rescinding offers.
Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58485/
-----------------------------------------------------------
(Updated April 28, 2017, 3:42 p.m.)
Review request for mesos, James Peach and Jiang Yan Xu.
Changes
-------
Rebased.
Bugs: MESOS-7308
https://issues.apache.org/jira/browse/MESOS-7308
Repository: mesos
Description
-------
When a `DESTROY` is processed, we rescind all pending offers to which
persistent volumes have been offered. As soon as we rescind an offer,
the `Offer` object is freed; and hence, we should move on to the next
offer (even though there are multiple volumes being destroyed in
the same `ACCEPT` call).
Diffs (updated)
-----
src/master/master.cpp e8c2a96ff3407fb429e60cd9e66a8c4dc52b391b
src/tests/persistent_volume_tests.cpp 3eb7afe3de8e72ffb6502dfe12ef37ccd4ca2125
Diff: https://reviews.apache.org/r/58485/diff/3/
Changes: https://reviews.apache.org/r/58485/diff/2-3/
Testing
-------
Tests passed.
Thanks,
Anindya Sinha
Re: Review Request 58485: Avoid a corruption while rescinding offers.
Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58485/
-----------------------------------------------------------
(Updated April 19, 2017, 2:49 a.m.)
Review request for mesos, James Peach and Jiang Yan Xu.
Changes
-------
Addressed review comments.
Bugs: MESOS-7308
https://issues.apache.org/jira/browse/MESOS-7308
Repository: mesos
Description
-------
When a `DESTROY` is processed, we rescind all pending offers to which
persistent volumes have been offered. As soon as we rescind an offer,
the `Offer` object is freed; and hence, we should move on to the next
offer (even though there are multiple volumes being destroyed in
the same `ACCEPT` call).
Diffs (updated)
-----
src/master/master.cpp 52de2f91bdacf46f913c27382ad50b4f278ad297
src/tests/persistent_volume_tests.cpp 3eb7afe3de8e72ffb6502dfe12ef37ccd4ca2125
Diff: https://reviews.apache.org/r/58485/diff/2/
Changes: https://reviews.apache.org/r/58485/diff/1-2/
Testing
-------
Tests passed.
Thanks,
Anindya Sinha