[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7963: Trigger out of band VM state update via libvirt event when VM stops

["DaanHoogland (via GitHub)" <gi...@apache.org>]

DaanHoogland commented on code in PR #7963:
URL: https://github.com/apache/cloudstack/pull/7963#discussion_r1328538211


##########
core/src/main/java/com/cloud/resource/ResourceStatusUpdater.java:
##########
@@ -0,0 +1,11 @@
+package com.cloud.resource;

Review Comment:
   license



##########
core/src/main/java/com/cloud/resource/AgentStatusUpdater.java:
##########
@@ -0,0 +1,5 @@
+package com.cloud.resource;

Review Comment:
   license



##########
core/src/main/java/com/cloud/resource/AgentStatusUpdater.java:
##########
@@ -0,0 +1,5 @@
+package com.cloud.resource;
+
+public interface AgentStatusUpdater {

Review Comment:
   I see you added javadoc to `ResourceStatusUpdater`. Can you add some here as well?



##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:
##########
@@ -3590,9 +3603,60 @@ private StartupStorageCommand createLocalStoragePool(String localStoragePath, St
         } catch (final CloudRuntimeException e) {
             s_logger.debug("Unable to initialize local storage pool: " + e);
         }
+        setupLibvirtEventListener();
         return sscmd;
     }
 
+    private void setupLibvirtEventListener() {

Review Comment:
   this contains nested try catches. Can you refactor to make it more readable?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org