You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2021/12/31 02:52:00 UTC

[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #1664: [KYUUBI #1656] Fix dist failed with --spark-provided

pan3793 commented on a change in pull request #1664:
URL: https://github.com/apache/incubator-kyuubi/pull/1664#discussion_r776912963



##########
File path: build/dist
##########
@@ -171,7 +171,7 @@ fi
 
 MVN_DIST_OPT="-DskipTests"
 if [[ "$SPARK_PROVIDED" == "true" ]]; then
-  MVN_DIST_OPT="$MVN_DIST_OPT -Pflink-provided,spark-provided"
+  MVN_DIST_OPT="$MVN_DIST_OPT -Pspark-provided"

Review comment:
       We should also handle `FLINK_PROVIDED` here, we also need add somethings like
   ```
   if [[ "$FLINK_PROVIDED" == "true" ]]; then
     MVN_DIST_OPT="$MVN_DIST_OPT -Pflink-provided"
   fi
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org