You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by "echobravopapa (GitHub)" <gi...@apache.org> on 2018/09/21 16:05:26 UTC

[GitHub] [geode-native] echobravopapa commented on pull request #360: GEODE-5259: Fix clang (xcode 10) build breaks

I think a more complete refactor for this `metadataEqualTo` is in order... look at the call site of this method and let's think about if `DataSerializables` have meta data for comparison, maybe it all just gets removed...?  and we'll want a test to drive out the change in any case as there was not legit coverage for the previous change.

[ Full content available at: https://github.com/apache/geode-native/pull/360 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org