[GitHub] [hadoop] simbadzina commented on a diff in pull request #5674: HDFS-17020. RBF: mount table addAll should print failed records in std error

["simbadzina (via GitHub)" <gi...@apache.org>]

simbadzina commented on code in PR #5674:
URL: https://github.com/apache/hadoop/pull/5674#discussion_r1199299711


##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterAdminCLI.java:
##########
@@ -1918,6 +1920,9 @@ public void testAddMultipleMountPointsFailure() throws Exception {
             "-faulttolerant"};
     // mount points were already added
     assertNotEquals(0, ToolRunner.run(admin, argv));
+
+    assertTrue("The error message should return failed entries",
+        err.toString().contains("Cannot add mount points: [0SLASH0testAddMultiMountPoints-01"));

Review Comment:
   `/` and `:` are replaced here: https://github.com/apache/hadoop/blob/trunk/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/store/driver/impl/StateStoreSerializableImpl.java#L104
   
   Can you create a small function to reverse that so the keys in the error message are readable



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org