You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/02/09 08:51:08 UTC
[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue
#1916: modify LoggerServiceTest UT by mock
codecov-io edited a comment on issue #1916: modify LoggerServiceTest UT by mock
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1916#issuecomment-583820245
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1916?src=pr&el=h1) Report
> Merging [#1916](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1916?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/49b4d084b35a0d4ee9cdcf4ecb1ebafa03bc828e?src=pr&el=desc) will **increase** coverage by `0.72%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1916?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #1916 +/- ##
=========================================
+ Coverage 24.27% 25% +0.72%
=========================================
Files 298 298
Lines 14388 14390 +2
Branches 2371 2372 +1
=========================================
+ Hits 3493 3598 +105
+ Misses 10468 10344 -124
- Partials 427 448 +21
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1916?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...he/dolphinscheduler/api/service/LoggerService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1916/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvTG9nZ2VyU2VydmljZS5qYXZh) | `100% <100%> (+95%)` | :arrow_up: |
| [...scheduler/alert/template/AlertTemplateFactory.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1916/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC90ZW1wbGF0ZS9BbGVydFRlbXBsYXRlRmFjdG9yeS5qYXZh) | `42.85% <0%> (ø)` | :arrow_up: |
| [...org/apache/dolphinscheduler/api/log/LogClient.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1916/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2xvZy9Mb2dDbGllbnQuamF2YQ==) | `2.77% <0%> (+2.77%)` | :arrow_up: |
| [...he/dolphinscheduler/common/utils/ScriptRunner.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1916/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL1NjcmlwdFJ1bm5lci5qYXZh) | `58.04% <0%> (+58.04%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1916?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1916?src=pr&el=footer). Last update [49b4d08...e00ef49](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1916?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services