You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/05/10 19:21:12 UTC
[GitHub] [superset] pkdotson opened a new pull request, #20017: feat: hack db connection modal ctabtns
pkdotson opened a new pull request, #20017:
URL: https://github.com/apache/superset/pull/20017
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] pkdotson commented on a diff in pull request #20017: feat: hack db connection modal ctabtns
Posted by GitBox <gi...@apache.org>.
pkdotson commented on code in PR #20017:
URL: https://github.com/apache/superset/pull/20017#discussion_r913913461
##########
superset-frontend/src/components/DatabaseSelector/index.tsx:
##########
@@ -87,7 +87,7 @@ export type DatabaseObject = {
type SchemaValue = { label: string; value: string };
export interface DatabaseSelectorProps {
- db?: DatabaseObject;
+ db?: DatabaseObject | null | undefined;
Review Comment:
I think i was trying to appease ts in one of the props. But I removed and no issue came about
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #20017: feat: hack db connection modal ctabtns
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #20017:
URL: https://github.com/apache/superset/pull/20017#issuecomment-1132412864
@yousoph Ephemeral environment spinning up at http://34.218.80.71:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] pkdotson merged pull request #20017: feat: hack db connection modal ctabtns
Posted by GitBox <gi...@apache.org>.
pkdotson merged PR #20017:
URL: https://github.com/apache/superset/pull/20017
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] AAfghahi commented on a diff in pull request #20017: feat: hack db connection modal ctabtns
Posted by GitBox <gi...@apache.org>.
AAfghahi commented on code in PR #20017:
URL: https://github.com/apache/superset/pull/20017#discussion_r913889509
##########
superset-frontend/src/components/DatabaseSelector/index.tsx:
##########
@@ -87,7 +87,7 @@ export type DatabaseObject = {
type SchemaValue = { label: string; value: string };
export interface DatabaseSelectorProps {
- db?: DatabaseObject;
+ db?: DatabaseObject | null | undefined;
Review Comment:
I understand why it is null, but why does it also need to be undefined?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #20017: feat: hack db connection modal ctabtns
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #20017:
URL: https://github.com/apache/superset/pull/20017#issuecomment-1124343926
# [Codecov](https://codecov.io/gh/apache/superset/pull/20017?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#20017](https://codecov.io/gh/apache/superset/pull/20017?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (738fb00) into [master](https://codecov.io/gh/apache/superset/commit/9cf9f97a0cee74bc642e297a3bdb089e70fffe57?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9cf9f97) will **decrease** coverage by `0.00%`.
> The diff coverage is `46.66%`.
> :exclamation: Current head 738fb00 differs from pull request most recent head e01be75. Consider uploading reports for the commit e01be75 to get more accurate results
```diff
@@ Coverage Diff @@
## master #20017 +/- ##
==========================================
- Coverage 66.35% 66.34% -0.01%
==========================================
Files 1712 1712
Lines 64056 64085 +29
Branches 6741 6744 +3
==========================================
+ Hits 42504 42517 +13
- Misses 19841 19854 +13
- Partials 1711 1714 +3
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `51.29% <46.66%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/20017?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...frontend/src/components/DatabaseSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/20017/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YWJhc2VTZWxlY3Rvci9pbmRleC50c3g=) | `88.88% <ø> (ø)` | |
| [superset-frontend/src/utils/localStorageHelpers.ts](https://codecov.io/gh/apache/superset/pull/20017/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2xvY2FsU3RvcmFnZUhlbHBlcnMudHM=) | `90.00% <ø> (ø)` | |
| [...s/CRUD/data/database/DatabaseModal/ModalHeader.tsx](https://codecov.io/gh/apache/superset/pull/20017/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsL01vZGFsSGVhZGVyLnRzeA==) | `66.66% <ø> (ø)` | |
| [...c/views/CRUD/data/database/DatabaseModal/styles.ts](https://codecov.io/gh/apache/superset/pull/20017/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsL3N0eWxlcy50cw==) | `76.47% <ø> (-0.23%)` | :arrow_down: |
| [...c/views/CRUD/data/database/DatabaseModal/index.tsx](https://codecov.io/gh/apache/superset/pull/20017/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsL2luZGV4LnRzeA==) | `32.45% <25.00%> (-0.25%)` | :arrow_down: |
| [...nd/src/views/CRUD/data/dataset/AddDatasetModal.tsx](https://codecov.io/gh/apache/superset/pull/20017/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhc2V0L0FkZERhdGFzZXRNb2RhbC50c3g=) | `42.50% <50.00%> (+0.83%)` | :arrow_up: |
| [...ontend/src/views/CRUD/data/dataset/DatasetList.tsx](https://codecov.io/gh/apache/superset/pull/20017/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhc2V0L0RhdGFzZXRMaXN0LnRzeA==) | `55.17% <50.00%> (-0.15%)` | :arrow_down: |
| [...d/src/SqlLab/components/SqlEditorLeftBar/index.tsx](https://codecov.io/gh/apache/superset/pull/20017/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIvaW5kZXgudHN4) | `49.20% <62.50%> (+1.93%)` | :arrow_up: |
| [...et-frontend/src/components/TableSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/20017/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci9pbmRleC50c3g=) | `76.08% <100.00%> (+0.53%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/20017?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/20017?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9cf9f97...e01be75](https://codecov.io/gh/apache/superset/pull/20017?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jess-dillard commented on pull request #20017: feat: hack db connection modal ctabtns
Posted by GitBox <gi...@apache.org>.
jess-dillard commented on PR #20017:
URL: https://github.com/apache/superset/pull/20017#issuecomment-1133336573
@pkdotson @yousoph Let's make some styling changes. Make a quick Figma mock [here](https://www.figma.com/file/ZGRrjGFNGHYxlsqOQy7pz3/?node-id=1107%3A2558) (top part of modal only). Note there are some text tweaks as well.
<img width="758" alt="Screen Shot 2022-05-20 at 1 30 22 PM" src="https://user-images.githubusercontent.com/90715511/169606051-53ecaade-4814-491a-955a-0baac8f48d67.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] yousoph commented on pull request #20017: feat: hack db connection modal ctabtns
Posted by GitBox <gi...@apache.org>.
yousoph commented on PR #20017:
URL: https://github.com/apache/superset/pull/20017#issuecomment-1132411763
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] pkdotson commented on pull request #20017: feat: hack db connection modal ctabtns
Posted by GitBox <gi...@apache.org>.
pkdotson commented on PR #20017:
URL: https://github.com/apache/superset/pull/20017#issuecomment-1172445202
> @pkdotson @yousoph Let's make some styling changes. Make a quick Figma mock [here](https://www.figma.com/file/ZGRrjGFNGHYxlsqOQy7pz3/?node-id=1107%3A2558) (top part of modal only). Note there are some text tweaks as well.
>
> <img alt="Screen Shot 2022-05-20 at 1 30 22 PM" width="758" src="https://user-images.githubusercontent.com/90715511/169606051-53ecaade-4814-491a-955a-0baac8f48d67.png">
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #20017: feat: hack db connection modal ctabtns
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #20017:
URL: https://github.com/apache/superset/pull/20017#issuecomment-1175222778
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] pkdotson commented on a diff in pull request #20017: feat: hack db connection modal ctabtns
Posted by GitBox <gi...@apache.org>.
pkdotson commented on code in PR #20017:
URL: https://github.com/apache/superset/pull/20017#discussion_r913913461
##########
superset-frontend/src/components/DatabaseSelector/index.tsx:
##########
@@ -87,7 +87,7 @@ export type DatabaseObject = {
type SchemaValue = { label: string; value: string };
export interface DatabaseSelectorProps {
- db?: DatabaseObject;
+ db?: DatabaseObject | null | undefined;
Review Comment:
I think i was trying to appease ts in on the props. But I removed and no issue came about
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] yousoph commented on pull request #20017: feat: hack db connection modal ctabtns
Posted by GitBox <gi...@apache.org>.
yousoph commented on PR #20017:
URL: https://github.com/apache/superset/pull/20017#issuecomment-1133153563
@jess-dillard can you see if the styling on the second step of the db connection screen looks good to you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org