You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@seata.apache.org by "mehedikhan72 (via GitHub)" <gi...@apache.org> on 2025/03/16 23:50:52 UTC
[PR] docs: update CONTRIBUTING.md [incubator-seata]
mehedikhan72 opened a new pull request, #7226:
URL: https://github.com/apache/incubator-seata/pull/7226
I just started messing around with Seata and I noticed that the CONTRIBUTING.md was not written in standard English. There were a lot of improvements to be made.
I did my best.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] docs: update CONTRIBUTING.md [incubator-seata]
Posted by "xingfudeshi (via GitHub)" <gi...@apache.org>.
xingfudeshi merged PR #7226:
URL: https://github.com/apache/incubator-seata/pull/7226
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] docs: update CONTRIBUTING.md [incubator-seata]
Posted by "mehedikhan72 (via GitHub)" <gi...@apache.org>.
mehedikhan72 commented on PR #7226:
URL: https://github.com/apache/incubator-seata/pull/7226#issuecomment-2728697183
Hi @xingfudeshi , I added the github ID.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] docs: update CONTRIBUTING.md [incubator-seata]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #7226:
URL: https://github.com/apache/incubator-seata/pull/7226#issuecomment-2727810721
## [Codecov](https://app.codecov.io/gh/apache/incubator-seata/pull/7226?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 53.62%. Comparing base [(`e0dc0c3`)](https://app.codecov.io/gh/apache/incubator-seata/commit/e0dc0c379fab845d0685565ca543427f193578d0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`d1fb3c5`)](https://app.codecov.io/gh/apache/incubator-seata/commit/d1fb3c56880cde470a3b772913e32d2a4d119a5a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/incubator-seata/pull/7226?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## 2.x #7226 +/- ##
=========================================
Coverage 53.62% 53.62%
+ Complexity 7130 7129 -1
=========================================
Files 1171 1171
Lines 41619 41619
Branches 4877 4877
=========================================
+ Hits 22319 22320 +1
+ Misses 17191 17190 -1
Partials 2109 2109
```
[see 4 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-seata/pull/7226/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary>🚀 New features to boost your workflow: </summary>
- ❄ [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- 📦 [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] docs: update CONTRIBUTING.md [incubator-seata]
Posted by "xingfudeshi (via GitHub)" <gi...@apache.org>.
xingfudeshi commented on PR #7226:
URL: https://github.com/apache/incubator-seata/pull/7226#issuecomment-2727806379
@mehedikhan72 Well done. We need more native English speakers like you to assist in our improvement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] docs: update CONTRIBUTING.md [incubator-seata]
Posted by "xingfudeshi (via GitHub)" <gi...@apache.org>.
xingfudeshi commented on PR #7226:
URL: https://github.com/apache/incubator-seata/pull/7226#issuecomment-2727809825
Please include your GitHub ID in the pull request as well.
<img width="1065" alt="image" src="https://github.com/user-attachments/assets/3ae6f138-ae82-41ce-b2ce-a252b41e8414" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org