You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/04/28 10:27:00 UTC
[GitHub] [tvm] pfk-beta opened a new pull request, #11159: add target_host argument to tvmc compile command
pfk-beta opened a new pull request, #11159:
URL: https://github.com/apache/tvm/pull/11159
this solves #11158
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] pfk-beta commented on pull request #11159: add target_host argument to tvmc compile command
Posted by GitBox <gi...@apache.org>.
pfk-beta commented on PR #11159:
URL: https://github.com/apache/tvm/pull/11159#issuecomment-1112250820
Hi @Mousius - sure. Could you tell how to run tests locally?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Mousius commented on pull request #11159: add target_host argument to tvmc compile command
Posted by "Mousius (via GitHub)" <gi...@apache.org>.
Mousius commented on PR #11159:
URL: https://github.com/apache/tvm/pull/11159#issuecomment-1446172268
@pfk-beta any updates here? or should we close this for now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Mousius commented on pull request #11159: add target_host argument to tvmc compile command
Posted by GitBox <gi...@apache.org>.
Mousius commented on PR #11159:
URL: https://github.com/apache/tvm/pull/11159#issuecomment-1122190312
@pfk-beta you can use the example of how to invoke the CLI directly from here:
https://github.com/apache/tvm/blob/8d4f4dd73ff2d762ade38aa0f9e8e9fba5f933da/tests/python/driver/tvmc/test_command_line.py#L58-L60
And mock `relay.build` as seen here:
https://github.com/apache/tvm/blob/8d4f4dd73ff2d762ade38aa0f9e8e9fba5f933da/tests/python/driver/tvmc/test_compiler.py#L517
Which should give you a `mock_relay` that you can use [assert_called_with](https://docs.python.org/3/library/unittest.mock.html#unittest.mock.Mock.assert_called_with) to check that `target_host` is correctly being passed through.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] add target_host argument to tvmc compile command [tvm]
Posted by "happyme531 (via GitHub)" <gi...@apache.org>.
happyme531 commented on PR #11159:
URL: https://github.com/apache/tvm/pull/11159#issuecomment-1869044316
This PR fixed my problem, it is useful in many cases and shouldn't be closed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] pfk-beta commented on pull request #11159: add target_host argument to tvmc compile command
Posted by GitBox <gi...@apache.org>.
pfk-beta commented on PR #11159:
URL: https://github.com/apache/tvm/pull/11159#issuecomment-1117048598
@Mousius how to check in tests, that module was compiled with target_host?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] add target_host argument to tvmc compile command [tvm]
Posted by "pfk-beta (via GitHub)" <gi...@apache.org>.
pfk-beta commented on PR #11159:
URL: https://github.com/apache/tvm/pull/11159#issuecomment-1871202614
@happyme531 I closed it, because I didn't have time to do it, and I didn't have enough knowledge to write tests inside TVM. If you know a little bit about developing TVM, you can copy my MR and write tests for it. I'm not making promise, but I can try to do it in a few days...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] pfk-beta commented on pull request #11159: add target_host argument to tvmc compile command
Posted by "pfk-beta (via GitHub)" <gi...@apache.org>.
pfk-beta commented on PR #11159:
URL: https://github.com/apache/tvm/pull/11159#issuecomment-1446343449
> @pfk-beta any updates here? or should we close this for now?
I didn't make any update, I don't see any interested people, so I'm closing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] pfk-beta closed pull request #11159: add target_host argument to tvmc compile command
Posted by "pfk-beta (via GitHub)" <gi...@apache.org>.
pfk-beta closed pull request #11159: add target_host argument to tvmc compile command
URL: https://github.com/apache/tvm/pull/11159
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org