You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by "Andy Konwinski (JIRA)" <ji...@apache.org> on 2012/09/27 00:53:07 UTC

[jira] [Created] (MESOS-285) configure.macosx checks for version "10.7" but should check for 10.7 or greater

Andy Konwinski created MESOS-285:
------------------------------------

             Summary: configure.macosx checks for version "10.7" but should check for 10.7 or greater
                 Key: MESOS-285
                 URL: https://issues.apache.org/jira/browse/MESOS-285
             Project: Mesos
          Issue Type: Bug
          Components: build
    Affects Versions: 0.9.0
         Environment: Mac OS X Mountain Lion
            Reporter: Andy Konwinski


Starting in OS X 10.7 (Lion) the location of jni.h is different. The configure.macosx addresses this by checking for version 10.7 and adding the new location to JAVA_CPPFLAGS. However, the check currently only tests for version 10.7 when it should check for 10.7 or greater. See the exact line I'm talking about in the current head of trunk at https://github.com/apache/mesos/blob/fcc113f93113a32b26e668b7d27b1110e72a7dac/configure.macosx#L6

if test ! -z `sw_vers -productVersion | grep 10.7`; then

I believe a fix would be to have this line instead use Bash's extended test command (as suggested in the comment by user "Steev" on this blog post http://bkhome.org/blog/?viewDetailed=02199) which can compare dotted version numbers:

osx_version=`sw_vers -productVersion`
if [[ "$osx_version" == "10.7" || "$osx_version" > "10.7" ]]; then

At least, this seems to work for me on 10.8.1 (Mountain Lion).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Assigned] (MESOS-285) configure.macosx checks for version "10.7" but should check for 10.7 or greater

Posted by "Benjamin Mahler (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MESOS-285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benjamin Mahler reassigned MESOS-285:
-------------------------------------

    Assignee: Benjamin Mahler
    
> configure.macosx checks for version "10.7" but should check for 10.7 or greater
> -------------------------------------------------------------------------------
>
>                 Key: MESOS-285
>                 URL: https://issues.apache.org/jira/browse/MESOS-285
>             Project: Mesos
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.9.0
>         Environment: Mac OS X Mountain Lion
>            Reporter: Andy Konwinski
>            Assignee: Benjamin Mahler
>
> Starting in OS X 10.7 (Lion) the location of jni.h is different. The configure.macosx addresses this by checking for version 10.7 and adding the new location to JAVA_CPPFLAGS. However, the check currently only tests for version 10.7 when it should check for 10.7 or greater. See the exact line I'm talking about in the current head of trunk at https://github.com/apache/mesos/blob/fcc113f93113a32b26e668b7d27b1110e72a7dac/configure.macosx#L6
> if test ! -z `sw_vers -productVersion | grep 10.7`; then
> I believe a fix would be to have this line instead use Bash's extended test command (as suggested in the comment by user "Steev" on this blog post http://bkhome.org/blog/?viewDetailed=02199) which can compare dotted version numbers:
> osx_version=`sw_vers -productVersion`
> if [[ "$osx_version" == "10.7" || "$osx_version" > "10.7" ]]; then
> At least, this seems to work for me on 10.8.1 (Mountain Lion).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (MESOS-285) configure.macosx checks for version "10.7" but should check for 10.7 or greater

Posted by "Benjamin Mahler (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MESOS-285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13495779#comment-13495779 ] 

Benjamin Mahler commented on MESOS-285:
---------------------------------------

I've bundled a fix for this in a review I just sent out: https://reviews.apache.org/r/8026/
                
> configure.macosx checks for version "10.7" but should check for 10.7 or greater
> -------------------------------------------------------------------------------
>
>                 Key: MESOS-285
>                 URL: https://issues.apache.org/jira/browse/MESOS-285
>             Project: Mesos
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.9.0
>         Environment: Mac OS X Mountain Lion
>            Reporter: Andy Konwinski
>
> Starting in OS X 10.7 (Lion) the location of jni.h is different. The configure.macosx addresses this by checking for version 10.7 and adding the new location to JAVA_CPPFLAGS. However, the check currently only tests for version 10.7 when it should check for 10.7 or greater. See the exact line I'm talking about in the current head of trunk at https://github.com/apache/mesos/blob/fcc113f93113a32b26e668b7d27b1110e72a7dac/configure.macosx#L6
> if test ! -z `sw_vers -productVersion | grep 10.7`; then
> I believe a fix would be to have this line instead use Bash's extended test command (as suggested in the comment by user "Steev" on this blog post http://bkhome.org/blog/?viewDetailed=02199) which can compare dotted version numbers:
> osx_version=`sw_vers -productVersion`
> if [[ "$osx_version" == "10.7" || "$osx_version" > "10.7" ]]; then
> At least, this seems to work for me on 10.8.1 (Mountain Lion).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira