[GitHub] [airflow] kaxil commented on a change in pull request #8772: Correctly store non-default Nones in serialized tasks/dags

[GitBox <gi...@apache.org>]

kaxil commented on a change in pull request #8772:
URL: https://github.com/apache/airflow/pull/8772#discussion_r422119825



##########
File path: airflow/serialization/serialized_objects.py
##########
@@ -119,11 +120,16 @@ def _is_primitive(cls, var: Any) -> bool:
     @classmethod
     def _is_excluded(cls, var: Any, attrname: str, instance: Any) -> bool:
         """Types excluded from serialization."""
-        # pylint: disable=unused-argument
+
+        if var is None:
+            if not cls._is_constcutor_param(attrname, instance):

Review comment:
       ```suggestion
               if not cls._is_constructor_param(attrname, instance):
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org