You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by Nakomis <gi...@git.apache.org> on 2014/08/22 12:55:22 UTC
[GitHub] incubator-brooklyn pull request: Feature/output itemlist
GitHub user Nakomis opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/128
Feature/output itemlist
DO NOT MERGE
For early review only
Run with `all --jars /Users/Martin/Documents/brooklyn/usage/dist/target/brooklyn-dist/lib --output-folder /tmp/entityhtml`
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Nakomis/incubator-brooklyn feature/output-itemlist
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/128.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #128
----
commit c3a26d911746826b85de5262e336708bce00d32e
Author: Aled Sage <al...@gmail.com>
Date: 2014-08-13T12:59:56Z
Fix BrooklynTypes.loadDefinedBrooklynType
commit 17e51c98dbffbfb845b5ff034fda0f0099b33d22
Author: Aled Sage <al...@gmail.com>
Date: 2014-08-13T19:52:01Z
Adds MutableSet.copyOf(iterator)
commit 63596e52df951bc961f8b548a8506375b9fed5eb
Author: Aled Sage <al...@gmail.com>
Date: 2014-08-13T13:00:16Z
Adds ItemLister for getting entities etc
commit 62f7669e1629958ada9d4f231e27424350a3e150
Author: Aled Sage <al...@gmail.com>
Date: 2014-08-13T19:51:26Z
Extract AbstractMain to remove duplication
- CLI tools (Main and CloudExplorer) extend AbstractMain
commit 5135373b9b18c0692dedaea0dc110dba738ce8b3
Author: Aled Sage <al...@gmail.com>
Date: 2014-08-13T19:54:12Z
Add @Catalog annotation
commit b7f31b107a1047b536ae261a90db370538f60daf
Author: Aled Sage <al...@gmail.com>
Date: 2014-08-13T19:55:02Z
Deprecate unused GeneralPurposePolicy
commit da246bbfb676368c5890bde7b5f03b247f8d3a2b
Author: Martin Harris <gi...@nakomis.com>
Date: 2014-08-22T10:54:33Z
Creates first-pass at outputting entities, policies, locations and locationResolvers
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Feature/output itemlist
Posted by richardcloudsoft <gi...@git.apache.org>.
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/128#issuecomment-54804544
Two minor comments:
* I'd prefer that the files added under usage/cli/src/main/resources/ are moved into a subdirectory that is the same as the "itemlister" package name
* I'd prefer that some of the new classes had Javadoc attached to them
However generally looks good and once I've confirmed that I can run the process myself then I'll merge this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Feature/output itemlist
Posted by Nakomis <gi...@git.apache.org>.
Github user Nakomis commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/128#issuecomment-54277793
This should now be creating useable output
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Feature/output itemlist
Posted by Nakomis <gi...@git.apache.org>.
Github user Nakomis commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/128#issuecomment-54801012
Merged in @aledsage's and @alasdairhodge's changes. Should now be ready to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Feature/output itemlist
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/128
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---