You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/06/29 14:57:31 UTC

[GitHub] [incubator-devlake] krshkodes opened a new pull request, #2388: docs: emojis for readme

krshkodes opened a new pull request, #2388:
URL: https://github.com/apache/incubator-devlake/pull/2388

   # Summary
   
   Now with more and more projects using emojis, and other graphical means to make the readme look more attractive, and beautiful, I have added emojis to the headers..
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] warren830 merged pull request #2388: docs: emojis for readme

Posted by GitBox <gi...@apache.org>.
warren830 merged PR #2388:
URL: https://github.com/apache/incubator-devlake/pull/2388


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] krshkodes commented on a diff in pull request #2388: docs: emojis for readme

Posted by GitBox <gi...@apache.org>.
krshkodes commented on code in PR #2388:
URL: https://github.com/apache/incubator-devlake/pull/2388#discussion_r910593566


##########
README.md:
##########
@@ -6,19 +6,21 @@
 # Apache DevLake(Incubating)
 
 [![PRs Welcome](https://img.shields.io/badge/PRs-welcome-brightgreen.svg?style=flat&logo=github&color=2370ff&labelColor=454545)](http://makeapullrequest.com)
-![badge](https://github.com/apache/incubator-devlake/actions/workflows/test.yml/badge.svg)
+![Unit Test Status](https://github.com/apache/incubator-devlake/actions/workflows/test.yml/badge.svg)

Review Comment:
   I mean, like we have linked other things, is there any possible URL we could like Unit Test Status to?
   
   __
   [![sema-logo](https://app.semasoftware.com/img/sema-tray-logo.gif)](https://semasoftware.com/gh) &nbsp;**Summary:** :question: I have a question
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] krshkodes commented on a diff in pull request #2388: docs: emojis for readme

Posted by GitBox <gi...@apache.org>.
krshkodes commented on code in PR #2388:
URL: https://github.com/apache/incubator-devlake/pull/2388#discussion_r909977174


##########
README.md:
##########
@@ -6,19 +6,21 @@
 # Apache DevLake(Incubating)
 
 [![PRs Welcome](https://img.shields.io/badge/PRs-welcome-brightgreen.svg?style=flat&logo=github&color=2370ff&labelColor=454545)](http://makeapullrequest.com)
-![badge](https://github.com/apache/incubator-devlake/actions/workflows/test.yml/badge.svg)
+![Unit Test Status](https://github.com/apache/incubator-devlake/actions/workflows/test.yml/badge.svg)

Review Comment:
   I have a question, do we have something we could link to here?
   
   __
   [![sema-logo](https://app.semasoftware.com/img/sema-tray-logo.gif)](https://semasoftware.com/gh) &nbsp;**Summary:** :question: I have a question&nbsp; | &nbsp;**Tags:** Inefficient
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] likyh commented on pull request #2388: docs: emojis for readme

Posted by GitBox <gi...@apache.org>.
likyh commented on PR #2388:
URL: https://github.com/apache/incubator-devlake/pull/2388#issuecomment-1170737544

   That's interesting. 😁


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] warren830 commented on a diff in pull request #2388: docs: emojis for readme

Posted by GitBox <gi...@apache.org>.
warren830 commented on code in PR #2388:
URL: https://github.com/apache/incubator-devlake/pull/2388#discussion_r910588061


##########
README.md:
##########
@@ -6,19 +6,21 @@
 # Apache DevLake(Incubating)
 
 [![PRs Welcome](https://img.shields.io/badge/PRs-welcome-brightgreen.svg?style=flat&logo=github&color=2370ff&labelColor=454545)](http://makeapullrequest.com)
-![badge](https://github.com/apache/incubator-devlake/actions/workflows/test.yml/badge.svg)
+![Unit Test Status](https://github.com/apache/incubator-devlake/actions/workflows/test.yml/badge.svg)

Review Comment:
   do  you mean the summary part?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] warren830 commented on a diff in pull request #2388: docs: emojis for readme

Posted by GitBox <gi...@apache.org>.
warren830 commented on code in PR #2388:
URL: https://github.com/apache/incubator-devlake/pull/2388#discussion_r911703980


##########
README.md:
##########
@@ -6,19 +6,21 @@
 # Apache DevLake(Incubating)
 
 [![PRs Welcome](https://img.shields.io/badge/PRs-welcome-brightgreen.svg?style=flat&logo=github&color=2370ff&labelColor=454545)](http://makeapullrequest.com)
-![badge](https://github.com/apache/incubator-devlake/actions/workflows/test.yml/badge.svg)
+![Unit Test Status](https://github.com/apache/incubator-devlake/actions/workflows/test.yml/badge.svg)

Review Comment:
   > I mean, like we have linked other things, is there any possible URL we could like Unit Test Status to?
   > 
   > __ [![sema-logo](https://camo.githubusercontent.com/843687ee2a84b8cc104a1e4297c26c9db3d3f710080228887db6338b4550a240/68747470733a2f2f6170702e73656d61736f6674776172652e636f6d2f696d672f73656d612d747261792d6c6f676f2e676966)](https://semasoftware.com/gh) [ ![sema-logo](https://camo.githubusercontent.com/843687ee2a84b8cc104a1e4297c26c9db3d3f710080228887db6338b4550a240/68747470733a2f2f6170702e73656d61736f6674776172652e636f6d2f696d672f73656d612d747261792d6c6f676f2e676966) ](https://semasoftware.com/gh) [ ](https://semasoftware.com/gh)  **Summary:** ❓ I have a question
   
   Ah, thanks. Actually, we don't have anything to link here. I think maybe we should replace it by [Contributors](https://img.shields.io/github/contributors/apache/echarts?color=3ba272)](https://github.com/apache/incubator-devlake/graphs/contributors)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] warren830 commented on pull request #2388: docs: emojis for readme

Posted by GitBox <gi...@apache.org>.
warren830 commented on PR #2388:
URL: https://github.com/apache/incubator-devlake/pull/2388#issuecomment-1172040633

   Well, nice work, this makes the repo more vivid


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] warren830 commented on pull request #2388: docs: emojis for readme

Posted by GitBox <gi...@apache.org>.
warren830 commented on PR #2388:
URL: https://github.com/apache/incubator-devlake/pull/2388#issuecomment-1175743933

   @krshkodes Hi, would you like to join us on slack? We'd like to issue a certificate for you to honor your contribution


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] krshkodes commented on pull request #2388: docs: emojis for readme

Posted by GitBox <gi...@apache.org>.
krshkodes commented on PR #2388:
URL: https://github.com/apache/incubator-devlake/pull/2388#issuecomment-1180180799

   Thank you @warren830! I'm already on the slack! :D
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org