You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "aleksraiden (via GitHub)" <gi...@apache.org> on 2024/03/09 21:59:58 UTC
[PR] Get SonarCube tracking net code from latest release(2.8.0) [kvrocks]
aleksraiden opened a new pull request, #2147:
URL: https://github.com/apache/kvrocks/pull/2147
Add a latest release branch as sonar.newCode.referenceBranch to track a new code. Closes #2058
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Get SonarCube tracking net code from latest release (unstable branch) [kvrocks]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #2147:
URL: https://github.com/apache/kvrocks/pull/2147#issuecomment-1987272839
## [](https://sonarcloud.io/dashboard?id=apache_kvrocks&pullRequest=2147) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_kvrocks&pullRequest=2147&resolved=false&inNewCodePeriod=true)
 [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_kvrocks&pullRequest=2147&metric=new_accepted_issues&view=list)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_kvrocks&pullRequest=2147&resolved=false&inNewCodePeriod=true)
 No data about Coverage
 No data about Duplication
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_kvrocks&pullRequest=2147)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Get SonarCube tracking net code from latest release (unstable branch) [kvrocks]
Posted by "jihuayu (via GitHub)" <gi...@apache.org>.
jihuayu commented on PR #2147:
URL: https://github.com/apache/kvrocks/pull/2147#issuecomment-2002000986
@aleksraiden
Thank you for your help.
I am looking into this issue. Just a few more questions to deal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Get SonarCube tracking net code from latest release (unstable branch) [kvrocks]
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on PR #2147:
URL: https://github.com/apache/kvrocks/pull/2147#issuecomment-2461370492
We are cleaning branches of this repo and this branch seems stale for a long time.
I'll close it and delete this branch. Feel free to submit a new patch if you want.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Get SonarCube tracking net code from latest release (unstable branch) [kvrocks]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #2147:
URL: https://github.com/apache/kvrocks/pull/2147#issuecomment-2002100621
## [](https://sonarcloud.io/dashboard?id=apache_kvrocks&pullRequest=2147) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_kvrocks&pullRequest=2147&resolved=false&inNewCodePeriod=true)
 [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_kvrocks&pullRequest=2147&metric=new_accepted_issues&view=list)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_kvrocks&pullRequest=2147&resolved=false&inNewCodePeriod=true)
 No data about Coverage
 No data about Duplication
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_kvrocks&pullRequest=2147)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Get SonarCube tracking net code from latest release(2.8.0) [kvrocks]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #2147:
URL: https://github.com/apache/kvrocks/pull/2147#issuecomment-1987005054
## [](https://sonarcloud.io/dashboard?id=apache_kvrocks&pullRequest=2147) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_kvrocks&pullRequest=2147&resolved=false&inNewCodePeriod=true)
 [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_kvrocks&pullRequest=2147&metric=new_accepted_issues&view=list)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_kvrocks&pullRequest=2147&resolved=false&inNewCodePeriod=true)
 No data about Coverage
 No data about Duplication
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_kvrocks&pullRequest=2147)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Get SonarCube tracking net code from latest release (unstable branch) [kvrocks]
Posted by "aleksraiden (via GitHub)" <gi...@apache.org>.
aleksraiden commented on PR #2147:
URL: https://github.com/apache/kvrocks/pull/2147#issuecomment-2001950065
@jihuayu thanks about your investigation, you are absolutely correct, I see a docs about sonar cube, not a cloud version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Get SonarCube tracking net code from latest release (unstable branch) [kvrocks]
Posted by "aleksraiden (via GitHub)" <gi...@apache.org>.
aleksraiden commented on code in PR #2147:
URL: https://github.com/apache/kvrocks/pull/2147#discussion_r1518739468
##########
.github/workflows/sonar.yaml:
##########
@@ -81,4 +81,5 @@ jobs:
--define sonar.projectKey=apache_kvrocks \
--define sonar.organization=apache \
--define sonar.scm.revision=${{ github.event.workflow_run.head_sha }} \
- --define sonar.pullrequest.key=$PR_NUMBER
+ --define sonar.pullrequest.key=$PR_NUMBER \
+ --define sonar.newCode.referenceBranch=2.8
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Get SonarCube tracking net code from latest release (unstable branch) [kvrocks]
Posted by "jihuayu (via GitHub)" <gi...@apache.org>.
jihuayu commented on PR #2147:
URL: https://github.com/apache/kvrocks/pull/2147#issuecomment-1987454923
I am testing this modification on my test project to see if it takes effect. This will take some time, please wait.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Get SonarCube tracking net code from latest release (unstable branch) [kvrocks]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #2147:
URL: https://github.com/apache/kvrocks/pull/2147#issuecomment-1987241072
## [](https://sonarcloud.io/dashboard?id=apache_kvrocks&pullRequest=2147) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_kvrocks&pullRequest=2147&resolved=false&inNewCodePeriod=true)
 [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_kvrocks&pullRequest=2147&metric=new_accepted_issues&view=list)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_kvrocks&pullRequest=2147&resolved=false&inNewCodePeriod=true)
 No data about Coverage
 No data about Duplication
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_kvrocks&pullRequest=2147)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Get SonarCube tracking net code from latest release(2.8.0) [kvrocks]
Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk commented on code in PR #2147:
URL: https://github.com/apache/kvrocks/pull/2147#discussion_r1518709143
##########
.github/workflows/sonar.yaml:
##########
@@ -81,4 +81,5 @@ jobs:
--define sonar.projectKey=apache_kvrocks \
--define sonar.organization=apache \
--define sonar.scm.revision=${{ github.event.workflow_run.head_sha }} \
- --define sonar.pullrequest.key=$PR_NUMBER
+ --define sonar.pullrequest.key=$PR_NUMBER \
+ --define sonar.newCode.referenceBranch=2.8
Review Comment:
We should use the unstable branch instead of 2.8 since all new updates are merged into the unstable branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Get SonarCube tracking net code from latest release (unstable branch) [kvrocks]
Posted by "jihuayu (via GitHub)" <gi...@apache.org>.
jihuayu commented on PR #2147:
URL: https://github.com/apache/kvrocks/pull/2147#issuecomment-1987531935
I have a try, but it doesn't work in my repo. Does it work in your repo?
Following the doc, It seems like the `sonar.newCode.referenceBranch` option is only supported by SonarQube.
In SonarCloud we don't have this option.
SonarCloud only version and Number of days.
Maybe we can use the `Specific date` option, and use the last 30 days' code as new code in sonarcloud setting. @git-hulk
This option can fixed https://github.com/apache/kvrocks/issues/2059.
And the https://github.com/apache/kvrocks/issues/2058 is another problem. I am trying it in [my repo](https://github.com/jihuayu/kvrocks-test/pull/2).
## Refer:
- [the new code options for SonarQube](https://docs.sonarsource.com/sonarqube/latest/project-administration/clean-as-you-code-settings/defining-new-code/#new-code-definition-options)
- [the new code options for SonarCloud](https://docs.sonarsource.com/sonarcloud/improving/new-code-definition/#new-code-definition-options)
- [the SonarCloud PR example](https://docs.sonarsource.com/sonarcloud/advanced-setup/ci-based-analysis/other-cis/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Get SonarCube tracking net code from latest release (unstable branch) [kvrocks]
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice closed pull request #2147: Get SonarCube tracking net code from latest release (unstable branch)
URL: https://github.com/apache/kvrocks/pull/2147
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org