svn commit: r1843121 - /jmeter/trunk/src/core/org/apache/jmeter/engine/ClientJMeterEngine.java

[pm...@apache.org]

Author: pmouawad
Date: Mon Oct  8 09:22:02 2018
New Revision: 1843121

URL: http://svn.apache.org/viewvc?rev=1843121&view=rev
Log:
Improve logging 

Modified:
    jmeter/trunk/src/core/org/apache/jmeter/engine/ClientJMeterEngine.java

Modified: jmeter/trunk/src/core/org/apache/jmeter/engine/ClientJMeterEngine.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/engine/ClientJMeterEngine.java?rev=1843121&r1=1843120&r2=1843121&view=diff
==============================================================================
--- jmeter/trunk/src/core/org/apache/jmeter/engine/ClientJMeterEngine.java (original)
+++ jmeter/trunk/src/core/org/apache/jmeter/engine/ClientJMeterEngine.java Mon Oct  8 09:22:02 2018
@@ -51,7 +51,7 @@ public class ClientJMeterEngine implemen
      * Maybe only host or host:port
      */
     private final String hostAndPort;
-
+    
     private static RemoteJMeterEngine getEngine(String hostAndPort) 
             throws RemoteException, NotBoundException {
         final String name = RemoteJMeterEngineImpl.JMETER_ENGINE_RMI_NAME; // $NON-NLS-1$ $NON-NLS-2$
@@ -95,7 +95,7 @@ public class ClientJMeterEngine implemen
     /** {@inheritDoc} */
     @Override
     public void stopTest(boolean now) {
-        log.info("about to {} remote test on {}", now ? "stop" : "shutdown", hostAndPort);
+        log.info("About to {} remote test on {}", now ? "stop" : "shutdown", hostAndPort);
         try {
             remote.rstopTest(now);
         } catch (Exception ex) {
@@ -110,7 +110,7 @@ public class ClientJMeterEngine implemen
             try {
                 remote.rreset();
             } catch (java.rmi.ConnectException e) {
-                log.info("Retry reset after: "+e);
+                log.info("Retry reset after: {}", e.getMessage());
                 remote = getEngine(hostAndPort);
                 remote.rreset();
             }
@@ -159,7 +159,7 @@ public class ClientJMeterEngine implemen
                 methodName="rsetProperties()";// NOSONAR Used for tracing
                 remote.rsetProperties(savep);
             } catch (RemoteException e) {
-                log.warn("Could not set properties: " + e.toString());
+                log.warn("Could not set properties: {}, error:{}", savep, e.getMessage(), e);
             }
             methodName="rrunTest()";
             remote.rrunTest();
@@ -169,7 +169,7 @@ public class ClientJMeterEngine implemen
             tidyRMI(log);
             throw ex; // Don't wrap this error - display it as is
         } catch (Exception ex) {
-            log.error("Error in "+methodName+" method "+ex); // $NON-NLS-1$ $NON-NLS-2$
+            log.error("Error in {} method", methodName, ex); // $NON-NLS-1$ $NON-NLS-2$
             tidyRMI(log);
             throw new JMeterEngineException("Error in "+methodName+" method "+ex, ex); // $NON-NLS-1$ $NON-NLS-2$
         }
@@ -202,7 +202,7 @@ public class ClientJMeterEngine implemen
             log.warn("Could not perform remote exit: " + e.toString());
         }
     }
-
+    
     private Properties savep;
     
     /** {@inheritDoc} */