(impala) 02/02: IMPALA-14940 (addendum): Added Jiras for broken tests

[st...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

asf-gitbox-commits pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git

commit 8d21d00778e975b4107a79aa893bd9d2995ad38a
Author: Steve Carlin <sc...@cloudera.com>
AuthorDate: Wed Oct 21 19:24:46 2026 -0700

    IMPALA-14940 (addendum): Added Jiras for broken tests
    
    Some tests were broken because hints are now handled in
    the Calcite planner.
    
    IMPALA-15613 has a bad cardinality for a filter in Kudu.
    
    For the following query:
    
    select * from functional_kudu.alltypes
    where greatest(functional_kudu.alltypes.month, 1000) IS NOT NULL
    
    The cardinality estimate shows 10% of the actual rows returned
    (730 versus 7300)
    
    Something seems wrong with the cardinality estimate for the filter.
    
    IMPALA-15614 was created for a test that uses the join hint "foo"
    which should produce a warning, but does not in the Calcite planner.
    
    Change-Id: I5b88caebe0147d3059d57cd1d8c5787f9b044ff1
    Reviewed-on: http://gerrit.cloudera.org:8080/25180
    Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
    Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
 .../workloads/functional-query/queries/QueryTest/runtime_filters.test | 4 ++++
 tests/common/skip.py                                                  | 2 ++
 tests/custom_cluster/test_hs2_fault_injection.py                      | 2 ++
 3 files changed, 8 insertions(+)

diff --git a/testdata/workloads/functional-query/queries/QueryTest/runtime_filters.test b/testdata/workloads/functional-query/queries/QueryTest/runtime_filters.test
index 912ea1b416..0049bc65f7 100644
--- a/testdata/workloads/functional-query/queries/QueryTest/runtime_filters.test
+++ b/testdata/workloads/functional-query/queries/QueryTest/runtime_filters.test
@@ -127,6 +127,10 @@ aggregation(SUM, RowsRead): 8
 aggregation(SUM, Files rejected): 24
 ---- RUNTIME_PROFILE: table_format=kudu
 row_regex: 00:SCAN KUDU.*s[ ]+7.30K[ ]+7.30K
+---- CALCITE_PLANNER_RUNTIME_PROFILE: table_format=kudu
+# IMPALA-15613 : Calcite adds a "greatest() IS NOT NULL" predicate which
+# incorrectly reduces the estimate by 90%.
+row_regex: 00:SCAN KUDU.*s[ ]+7.30K[ ]+730
 ====
 
 
diff --git a/tests/common/skip.py b/tests/common/skip.py
index 1c4d0c3e6e..6fc59307ad 100644
--- a/tests/common/skip.py
+++ b/tests/common/skip.py
@@ -315,3 +315,5 @@ class SkipIfCalcite:
       reason="IMPALA-15123: spilling plan is different, needs investigation.")
   processing_plan_different = pytest.mark.skipif(IS_CALCITE_PLANNER,
       reason="IMPALA-15260: processing plan is different, needs investigation.")
+  missing_join_hint_warning = pytest.mark.skipif(IS_CALCITE_PLANNER,
+      reason="IMPALA-15614: no warning for unsupported join hint.")
diff --git a/tests/custom_cluster/test_hs2_fault_injection.py b/tests/custom_cluster/test_hs2_fault_injection.py
index 638ed5f18a..cf4be9fe08 100644
--- a/tests/custom_cluster/test_hs2_fault_injection.py
+++ b/tests/custom_cluster/test_hs2_fault_injection.py
@@ -25,6 +25,7 @@ from impala_shell.ImpalaHttpClient import ImpalaHttpClient
 from impala_shell.shell_exceptions import HttpError
 from tests.common.custom_cluster_test_suite import CustomClusterTestSuite
 from tests.common.impala_test_suite import IMPALAD_HS2_HTTP_HOST_PORT
+from tests.common.skip import SkipIfCalcite
 
 """IMPALA-12216 implemented timestamp to be printed in case of any error/warning
   during query execution, below is an example :
@@ -402,6 +403,7 @@ class TestHS2FaultInjection(CustomClusterTestSuite):
     assert output[2][TS_LEN:] == self.__expect_msg_retry("GetExecSummary")
 
   @pytest.mark.execute_serially
+  @SkipIfCalcite.missing_join_hint_warning
   def test_get_warning_log(self, capsys):
     """Tests fault injection in ImpalaHS2Client's get_warning_log().
     GetLog rpc fails due to fault, but succeeds after a retry"""