You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by "Virag Kothari (Created) (JIRA)" <ji...@apache.org> on 2011/12/06 22:23:42 UTC
[jira] [Created] (OOZIE-628) Add libraries which can be used by all
actions in oozie
Add libraries which can be used by all actions in oozie
-------------------------------------------------------
Key: OOZIE-628
URL: https://issues.apache.org/jira/browse/OOZIE-628
Project: Oozie
Issue Type: Improvement
Reporter: Virag Kothari
In Oozie - 610, action specific share libs are added. This JIRA proposes an enhancement to it where libraries are added which can be shared by all actions.
For e.g, I am modifying Pig to store the stats. But Json library is required to do so. By putting the json lib at a common location, other actions like hive, distcp can use this library in future.
For e.g, all common libs can be stored in
/share/lib/oozie/*
Also, all action specific share libs will override the common libs
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OOZIE-628) Add libraries which can be used by all
actions in oozie
Posted by "Virag Kothari (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Virag Kothari updated OOZIE-628:
--------------------------------
For the patch committed in trunk with this JIRA ID (also available under the same JIRA ID in Apache ReviewBoard system), I grant license to ASF for inclusion in ASF works (as per the Apache License ยง5)
> Add libraries which can be used by all actions in oozie
> -------------------------------------------------------
>
> Key: OOZIE-628
> URL: https://issues.apache.org/jira/browse/OOZIE-628
> Project: Oozie
> Issue Type: Improvement
> Reporter: Virag Kothari
> Assignee: Virag Kothari
> Fix For: 3.2.0
>
>
> In Oozie - 610, action specific share libs are added. This JIRA proposes an enhancement to it where libraries are added which can be shared by all actions.
> For e.g, I am modifying Pig to store the stats. But Json library is required to do so. By putting the json lib at a common location, other actions like hive, distcp can use this library in future.
> For e.g, all common libs can be stored in
> /share/lib/oozie/*
> Also, all action specific share libs will override the common libs
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (OOZIE-628) Add libraries which can be used by all
actions in oozie
Posted by "Virag Kothari (Closed) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Virag Kothari closed OOZIE-628.
-------------------------------
Resolution: Fixed
> Add libraries which can be used by all actions in oozie
> -------------------------------------------------------
>
> Key: OOZIE-628
> URL: https://issues.apache.org/jira/browse/OOZIE-628
> Project: Oozie
> Issue Type: Improvement
> Reporter: Virag Kothari
>
> In Oozie - 610, action specific share libs are added. This JIRA proposes an enhancement to it where libraries are added which can be shared by all actions.
> For e.g, I am modifying Pig to store the stats. But Json library is required to do so. By putting the json lib at a common location, other actions like hive, distcp can use this library in future.
> For e.g, all common libs can be stored in
> /share/lib/oozie/*
> Also, all action specific share libs will override the common libs
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-628) Add libraries which can be used by
all actions in oozie
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13163911#comment-13163911 ]
jiraposter@reviews.apache.org commented on OOZIE-628:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3039/
-----------------------------------------------------------
Review request for oozie, Mohammad Islam, Angelo K. Huang, and Alejandro Abdelnur.
Summary
-------
Add libraries which can be used by all actions in oozie
https://issues.apache.org/jira/browse/OOZIE-628
This addresses bug OOZIE-628.
https://issues.apache.org/jira/browse/OOZIE-628
Diffs
-----
trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1211066
trunk/release-log.txt 1211066
Diff: https://reviews.apache.org/r/3039/diff
Testing
-------
Tested against current test cases
Thanks,
Virag
> Add libraries which can be used by all actions in oozie
> -------------------------------------------------------
>
> Key: OOZIE-628
> URL: https://issues.apache.org/jira/browse/OOZIE-628
> Project: Oozie
> Issue Type: Improvement
> Reporter: Virag Kothari
>
> In Oozie - 610, action specific share libs are added. This JIRA proposes an enhancement to it where libraries are added which can be shared by all actions.
> For e.g, I am modifying Pig to store the stats. But Json library is required to do so. By putting the json lib at a common location, other actions like hive, distcp can use this library in future.
> For e.g, all common libs can be stored in
> /share/lib/oozie/*
> Also, all action specific share libs will override the common libs
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OOZIE-628) Add libraries which can be used by all
actions in oozie
Posted by "Alejandro Abdelnur (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alejandro Abdelnur updated OOZIE-628:
-------------------------------------
Fix Version/s: 3.2.0
> Add libraries which can be used by all actions in oozie
> -------------------------------------------------------
>
> Key: OOZIE-628
> URL: https://issues.apache.org/jira/browse/OOZIE-628
> Project: Oozie
> Issue Type: Improvement
> Reporter: Virag Kothari
> Fix For: 3.2.0
>
>
> In Oozie - 610, action specific share libs are added. This JIRA proposes an enhancement to it where libraries are added which can be shared by all actions.
> For e.g, I am modifying Pig to store the stats. But Json library is required to do so. By putting the json lib at a common location, other actions like hive, distcp can use this library in future.
> For e.g, all common libs can be stored in
> /share/lib/oozie/*
> Also, all action specific share libs will override the common libs
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-628) Add libraries which can be used by
all actions in oozie
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13164649#comment-13164649 ]
jiraposter@reviews.apache.org commented on OOZIE-628:
-----------------------------------------------------
bq. On 2011-12-06 22:31:44, Alejandro Abdelnur wrote:
bq. > Please test building a distribution and running the examples as testcases don't test actual sharelib usage (the JARs are in the testclasspath already)
ok
bq. On 2011-12-06 22:31:44, Alejandro Abdelnur wrote:
bq. > trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java, line 437
bq. > <https://reviews.apache.org/r/3039/diff/1/?file=62631#file62631line437>
bq. >
bq. > the action sharelib should be added outside of this method.
ok
bq. On 2011-12-06 22:31:44, Alejandro Abdelnur wrote:
bq. > trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java, line 438
bq. > <https://reviews.apache.org/r/3039/diff/1/?file=62631#file62631line438>
bq. >
bq. > is the oozie sharelib always added and the action sharelibs only if the USE_SYSTEM_LIBPATH is set?
bq. >
bq. > this is kind of confusing.
Yes, Oozie Sharelibs which are common to all actions will always be added. Action share libs will only be added if use_system_libpath is set to true.
bq. On 2011-12-06 22:31:44, Alejandro Abdelnur wrote:
bq. > trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java, line 428
bq. > <https://reviews.apache.org/r/3039/diff/1/?file=62631#file62631line428>
bq. >
bq. > this is not an actionsharelib, the method should be renamed to addShareLib
ok
bq. On 2011-12-06 22:31:44, Alejandro Abdelnur wrote:
bq. > trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java, line 425
bq. > <https://reviews.apache.org/r/3039/diff/1/?file=62631#file62631line425>
bq. >
bq. > The JIRA states that action JARs have precedence over the oozie lib JARs but the logic here is the other way around.
good catch, will change the logic
- Virag
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3039/#review3677
-----------------------------------------------------------
On 2011-12-06 22:15:07, Virag Kothari wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3039/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-12-06 22:15:07)
bq.
bq.
bq. Review request for oozie, Mohammad Islam, Angelo K. Huang, and Alejandro Abdelnur.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Add libraries which can be used by all actions in oozie
bq.
bq. https://issues.apache.org/jira/browse/OOZIE-628
bq.
bq.
bq. This addresses bug OOZIE-628.
bq. https://issues.apache.org/jira/browse/OOZIE-628
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1211066
bq. trunk/release-log.txt 1211066
bq.
bq. Diff: https://reviews.apache.org/r/3039/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Tested against current test cases
bq.
bq.
bq. Thanks,
bq.
bq. Virag
bq.
bq.
> Add libraries which can be used by all actions in oozie
> -------------------------------------------------------
>
> Key: OOZIE-628
> URL: https://issues.apache.org/jira/browse/OOZIE-628
> Project: Oozie
> Issue Type: Improvement
> Reporter: Virag Kothari
>
> In Oozie - 610, action specific share libs are added. This JIRA proposes an enhancement to it where libraries are added which can be shared by all actions.
> For e.g, I am modifying Pig to store the stats. But Json library is required to do so. By putting the json lib at a common location, other actions like hive, distcp can use this library in future.
> For e.g, all common libs can be stored in
> /share/lib/oozie/*
> Also, all action specific share libs will override the common libs
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-628) Add libraries which can be used by
all actions in oozie
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13164694#comment-13164694 ]
jiraposter@reviews.apache.org commented on OOZIE-628:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3039/
-----------------------------------------------------------
(Updated 2011-12-07 20:58:45.422616)
Review request for oozie, Mohammad Islam, Angelo K. Huang, and Alejandro Abdelnur.
Changes
-------
Incorporated reviewers comments
Summary
-------
Add libraries which can be used by all actions in oozie
https://issues.apache.org/jira/browse/OOZIE-628
This addresses bug OOZIE-628.
https://issues.apache.org/jira/browse/OOZIE-628
Diffs (updated)
-----
trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1211066
Diff: https://reviews.apache.org/r/3039/diff
Testing
-------
Tested against current test cases
Thanks,
Virag
> Add libraries which can be used by all actions in oozie
> -------------------------------------------------------
>
> Key: OOZIE-628
> URL: https://issues.apache.org/jira/browse/OOZIE-628
> Project: Oozie
> Issue Type: Improvement
> Reporter: Virag Kothari
>
> In Oozie - 610, action specific share libs are added. This JIRA proposes an enhancement to it where libraries are added which can be shared by all actions.
> For e.g, I am modifying Pig to store the stats. But Json library is required to do so. By putting the json lib at a common location, other actions like hive, distcp can use this library in future.
> For e.g, all common libs can be stored in
> /share/lib/oozie/*
> Also, all action specific share libs will override the common libs
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-628) Add libraries which can be used by
all actions in oozie
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13166213#comment-13166213 ]
jiraposter@reviews.apache.org commented on OOZIE-628:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3039/#review3781
-----------------------------------------------------------
Ship it!
- Alejandro
On 2011-12-07 20:58:45, Virag Kothari wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3039/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-12-07 20:58:45)
bq.
bq.
bq. Review request for oozie, Mohammad Islam, Angelo K. Huang, and Alejandro Abdelnur.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Add libraries which can be used by all actions in oozie
bq.
bq. https://issues.apache.org/jira/browse/OOZIE-628
bq.
bq.
bq. This addresses bug OOZIE-628.
bq. https://issues.apache.org/jira/browse/OOZIE-628
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1211066
bq.
bq. Diff: https://reviews.apache.org/r/3039/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Tested against current test cases
bq.
bq.
bq. Thanks,
bq.
bq. Virag
bq.
bq.
> Add libraries which can be used by all actions in oozie
> -------------------------------------------------------
>
> Key: OOZIE-628
> URL: https://issues.apache.org/jira/browse/OOZIE-628
> Project: Oozie
> Issue Type: Improvement
> Reporter: Virag Kothari
>
> In Oozie - 610, action specific share libs are added. This JIRA proposes an enhancement to it where libraries are added which can be shared by all actions.
> For e.g, I am modifying Pig to store the stats. But Json library is required to do so. By putting the json lib at a common location, other actions like hive, distcp can use this library in future.
> For e.g, all common libs can be stored in
> /share/lib/oozie/*
> Also, all action specific share libs will override the common libs
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-628) Add libraries which can be used by
all actions in oozie
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13163930#comment-13163930 ]
jiraposter@reviews.apache.org commented on OOZIE-628:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3039/#review3677
-----------------------------------------------------------
Please test building a distribution and running the examples as testcases don't test actual sharelib usage (the JARs are in the testclasspath already)
trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
<https://reviews.apache.org/r/3039/#comment8185>
The JIRA states that action JARs have precedence over the oozie lib JARs but the logic here is the other way around.
trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
<https://reviews.apache.org/r/3039/#comment8186>
this is not an actionsharelib, the method should be renamed to addShareLib
trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
<https://reviews.apache.org/r/3039/#comment8187>
the action sharelib should be added outside of this method.
trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
<https://reviews.apache.org/r/3039/#comment8188>
is the oozie sharelib always added and the action sharelibs only if the USE_SYSTEM_LIBPATH is set?
this is kind of confusing.
trunk/release-log.txt
<https://reviews.apache.org/r/3039/#comment8182>
the patch should not modify the release-log.txt file, this should be done by the committer.
- Alejandro
On 2011-12-06 22:15:07, Virag Kothari wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3039/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-12-06 22:15:07)
bq.
bq.
bq. Review request for oozie, Mohammad Islam, Angelo K. Huang, and Alejandro Abdelnur.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Add libraries which can be used by all actions in oozie
bq.
bq. https://issues.apache.org/jira/browse/OOZIE-628
bq.
bq.
bq. This addresses bug OOZIE-628.
bq. https://issues.apache.org/jira/browse/OOZIE-628
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1211066
bq. trunk/release-log.txt 1211066
bq.
bq. Diff: https://reviews.apache.org/r/3039/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Tested against current test cases
bq.
bq.
bq. Thanks,
bq.
bq. Virag
bq.
bq.
> Add libraries which can be used by all actions in oozie
> -------------------------------------------------------
>
> Key: OOZIE-628
> URL: https://issues.apache.org/jira/browse/OOZIE-628
> Project: Oozie
> Issue Type: Improvement
> Reporter: Virag Kothari
>
> In Oozie - 610, action specific share libs are added. This JIRA proposes an enhancement to it where libraries are added which can be shared by all actions.
> For e.g, I am modifying Pig to store the stats. But Json library is required to do so. By putting the json lib at a common location, other actions like hive, distcp can use this library in future.
> For e.g, all common libs can be stored in
> /share/lib/oozie/*
> Also, all action specific share libs will override the common libs
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira