You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2012/03/21 18:43:24 UTC
Review Request: Added new TASK_STAGING task state
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4433/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and John Sirois.
Summary
-------
To avoid ambiguity between the TASK_STARTING state that could be sent by the executors, added a new TASK_STAGING state.
This state should only be used by mesos core and a status update with this state is explicitly disallowed from executors.
Diffs
-----
include/mesos/mesos.proto 478f561
src/exec/exec.cpp 53f7e54
src/master/http.cpp 628112b
src/master/master.cpp 6ae8aef
src/slave/http.cpp e259642
src/slave/slave.hpp b7bc45a
src/slave/slave.cpp 9332caa
Diff: https://reviews.apache.org/r/4433/diff
Testing
-------
make check
Thanks,
Vinod
Re: Review Request: Added new TASK_STAGING task state
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4433/#review6330
-----------------------------------------------------------
Ship it!
Thanks Vinod.
- Benjamin
On 2012-03-23 17:20:46, Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4433/
> -----------------------------------------------------------
>
> (Updated 2012-03-23 17:20:46)
>
>
> Review request for mesos, Benjamin Hindman and John Sirois.
>
>
> Summary
> -------
>
> To avoid ambiguity between the TASK_STARTING state that could be sent by the executors, added a new TASK_STAGING state.
>
> This state should only be used by mesos core and a status update with this state is explicitly disallowed from executors.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 478f561
> src/exec/exec.cpp 53f7e54
> src/master/http.cpp 628112b
> src/master/master.cpp 6ae8aef
> src/slave/http.cpp e259642
> src/slave/slave.hpp b7bc45a
> src/slave/slave.cpp 9332caa
>
> Diff: https://reviews.apache.org/r/4433/diff
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod
>
>
Re: Review Request: Added new TASK_STAGING task state
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4433/
-----------------------------------------------------------
(Updated 2012-03-23 17:20:46.970844)
Review request for mesos, Benjamin Hindman and John Sirois.
Changes
-------
ben's comments.
Summary
-------
To avoid ambiguity between the TASK_STARTING state that could be sent by the executors, added a new TASK_STAGING state.
This state should only be used by mesos core and a status update with this state is explicitly disallowed from executors.
Diffs (updated)
-----
include/mesos/mesos.proto 478f561
src/exec/exec.cpp 53f7e54
src/master/http.cpp 628112b
src/master/master.cpp 6ae8aef
src/slave/http.cpp e259642
src/slave/slave.hpp b7bc45a
src/slave/slave.cpp 9332caa
Diff: https://reviews.apache.org/r/4433/diff
Testing
-------
make check
Thanks,
Vinod
Re: Review Request: Added new TASK_STAGING task state
Posted by Vinod Kone <vi...@gmail.com>.
> On 2012-03-21 18:26:09, Benjamin Hindman wrote:
> > include/mesos/mesos.proto, line 276
> > <https://reviews.apache.org/r/4433/diff/1/?file=94189#file94189line276>
> >
> > How about something like:
> > // Initial state, can not be transitioned to (via status updates).
fixed
> On 2012-03-21 18:26:09, Benjamin Hindman wrote:
> > include/mesos/mesos.proto, lines 277-282
> > <https://reviews.apache.org/r/4433/diff/1/?file=94189#file94189line277>
> >
> > Let's actually not change these numbers. Making TASK_STAGING be 6 is just fine.
done
> On 2012-03-21 18:26:09, Benjamin Hindman wrote:
> > src/exec/exec.cpp, line 230
> > <https://reviews.apache.org/r/4433/diff/1/?file=94190#file94190line230>
> >
> > What about aborting the framework instead?
done
> On 2012-03-21 18:26:09, Benjamin Hindman wrote:
> > src/master/master.cpp, lines 300-301
> > <https://reviews.apache.org/r/4433/diff/1/?file=94192#file94192line300>
> >
> > You can kill these two checks if you'd prefer.
killed
> On 2012-03-21 18:26:09, Benjamin Hindman wrote:
> > src/slave/slave.cpp, lines 197-198
> > <https://reviews.apache.org/r/4433/diff/1/?file=94195#file94195line197>
> >
> > Can kill these too (rather than making the complicated because of the weird number ordering).
killed
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4433/#review6176
-----------------------------------------------------------
On 2012-03-21 17:43:24, Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4433/
> -----------------------------------------------------------
>
> (Updated 2012-03-21 17:43:24)
>
>
> Review request for mesos, Benjamin Hindman and John Sirois.
>
>
> Summary
> -------
>
> To avoid ambiguity between the TASK_STARTING state that could be sent by the executors, added a new TASK_STAGING state.
>
> This state should only be used by mesos core and a status update with this state is explicitly disallowed from executors.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 478f561
> src/exec/exec.cpp 53f7e54
> src/master/http.cpp 628112b
> src/master/master.cpp 6ae8aef
> src/slave/http.cpp e259642
> src/slave/slave.hpp b7bc45a
> src/slave/slave.cpp 9332caa
>
> Diff: https://reviews.apache.org/r/4433/diff
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod
>
>
Re: Review Request: Added new TASK_STAGING task state
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4433/#review6176
-----------------------------------------------------------
include/mesos/mesos.proto
<https://reviews.apache.org/r/4433/#comment13294>
How about something like:
// Initial state, can not be transitioned to (via status updates).
include/mesos/mesos.proto
<https://reviews.apache.org/r/4433/#comment13295>
Let's actually not change these numbers. Making TASK_STAGING be 6 is just fine.
src/exec/exec.cpp
<https://reviews.apache.org/r/4433/#comment13298>
What about aborting the framework instead?
src/master/master.cpp
<https://reviews.apache.org/r/4433/#comment13296>
You can kill these two checks if you'd prefer.
src/slave/slave.cpp
<https://reviews.apache.org/r/4433/#comment13297>
Can kill these too (rather than making the complicated because of the weird number ordering).
- Benjamin
On 2012-03-21 17:43:24, Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4433/
> -----------------------------------------------------------
>
> (Updated 2012-03-21 17:43:24)
>
>
> Review request for mesos, Benjamin Hindman and John Sirois.
>
>
> Summary
> -------
>
> To avoid ambiguity between the TASK_STARTING state that could be sent by the executors, added a new TASK_STAGING state.
>
> This state should only be used by mesos core and a status update with this state is explicitly disallowed from executors.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 478f561
> src/exec/exec.cpp 53f7e54
> src/master/http.cpp 628112b
> src/master/master.cpp 6ae8aef
> src/slave/http.cpp e259642
> src/slave/slave.hpp b7bc45a
> src/slave/slave.cpp 9332caa
>
> Diff: https://reviews.apache.org/r/4433/diff
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod
>
>