You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org> on 2023/03/01 14:34:23 UTC
[Impala-ASF-CR] IMPALA-11572: deflake test mt dop skew lpt part 3
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19564
Change subject: IMPALA-11572: deflake test_mt_dop_skew_lpt part 3
......................................................................
IMPALA-11572: deflake test_mt_dop_skew_lpt part 3
test_mt_dop_skew_lpt is still flaky. It fails most of the
time on Ozone or when erasure coding is enabled. With this change
we won't execute this test in such configurations.
Also the skew threshold is decreased to 0.80.
Change-Id: I73917ca2179199fd1cd7247000cd4b2f6d33a510
---
M tests/query_test/test_scanners.py
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/19564/1
--
To view, visit http://gerrit.cloudera.org:8080/19564
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I73917ca2179199fd1cd7247000cd4b2f6d33a510
Gerrit-Change-Number: 19564
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-11572: deflake test mt dop skew lpt part 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19564 )
Change subject: IMPALA-11572: deflake test_mt_dop_skew_lpt part 3
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/12505/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19564
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I73917ca2179199fd1cd7247000cd4b2f6d33a510
Gerrit-Change-Number: 19564
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 Mar 2023 14:55:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11572: deflake test mt dop skew lpt part 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19564 )
Change subject: IMPALA-11572: deflake test_mt_dop_skew_lpt part 3
......................................................................
IMPALA-11572: deflake test_mt_dop_skew_lpt part 3
test_mt_dop_skew_lpt is still flaky. It fails most of the
time on Ozone or when erasure coding is enabled. With this change
we won't execute this test in such configurations.
Also the skew threshold is decreased to 0.80.
Change-Id: I73917ca2179199fd1cd7247000cd4b2f6d33a510
Reviewed-on: http://gerrit.cloudera.org:8080/19564
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Michael Smith <mi...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/query_test/test_scanners.py
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
Michael Smith: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.cloudera.org:8080/19564
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I73917ca2179199fd1cd7247000cd4b2f6d33a510
Gerrit-Change-Number: 19564
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-11572: deflake test mt dop skew lpt part 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19564 )
Change subject: IMPALA-11572: deflake test_mt_dop_skew_lpt part 3
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/19564
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I73917ca2179199fd1cd7247000cd4b2f6d33a510
Gerrit-Change-Number: 19564
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 Mar 2023 20:56:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11572: deflake test mt dop skew lpt part 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19564 )
Change subject: IMPALA-11572: deflake test_mt_dop_skew_lpt part 3
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9088/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/19564
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I73917ca2179199fd1cd7247000cd4b2f6d33a510
Gerrit-Change-Number: 19564
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 Mar 2023 15:49:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11572: deflake test mt dop skew lpt part 3
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19564 )
Change subject: IMPALA-11572: deflake test_mt_dop_skew_lpt part 3
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19564/2/tests/query_test/test_scanners.py
File tests/query_test/test_scanners.py:
http://gerrit.cloudera.org:8080/#/c/19564/2/tests/query_test/test_scanners.py@444
PS2, Line 444: assert cnt_fail <= 5
I'd been thinking of increasing this to 10 for Ozone/EC, since I haven't seen any failures go above that. But if that doesn't seem useful, disabling the test is fine.
--
To view, visit http://gerrit.cloudera.org:8080/19564
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I73917ca2179199fd1cd7247000cd4b2f6d33a510
Gerrit-Change-Number: 19564
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 Mar 2023 17:53:57 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11572: deflake test mt dop skew lpt part 3
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19564 )
Change subject: IMPALA-11572: deflake test_mt_dop_skew_lpt part 3
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19564
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I73917ca2179199fd1cd7247000cd4b2f6d33a510
Gerrit-Change-Number: 19564
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 Mar 2023 15:46:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11572: deflake test mt dop skew lpt part 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19564 )
Change subject: IMPALA-11572: deflake test_mt_dop_skew_lpt part 3
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19564
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I73917ca2179199fd1cd7247000cd4b2f6d33a510
Gerrit-Change-Number: 19564
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 Mar 2023 15:49:09 +0000
Gerrit-HasComments: No