You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/11/10 22:08:14 UTC

[GitHub] mistercrunch opened a new pull request #6365: [bugfix] deckgl legend is not interactive

mistercrunch opened a new pull request #6365: [bugfix] deckgl legend is not interactive
URL: https://github.com/apache/incubator-superset/pull/6365
 
 
   Somehow when clicking categories in the legend, nothing happened. The
   problem seemed to be around the `getDerivedStateFromProps` override
   which gets triggered after each render and would alter the state and
   reset the categories state to their origin.
   
   Changed the method name to not be an override and just be called once
   in the constructor
   
   https://reactjs.org/docs/react-component.html#static-getderivedstatefromprops

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org