You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "Weijun-H (via GitHub)" <gi...@apache.org> on 2023/12/15 22:56:30 UTC
[PR] feat: support largelist in array_slice [arrow-datafusion]
Weijun-H opened a new pull request, #8561:
URL: https://github.com/apache/arrow-datafusion/pull/8561
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: support largelist in array_slice [arrow-datafusion]
Posted by "jayzhan211 (via GitHub)" <gi...@apache.org>.
jayzhan211 commented on code in PR #8561:
URL: https://github.com/apache/arrow-datafusion/pull/8561#discussion_r1428621263
##########
datafusion/physical-expr/src/array_expressions.rs:
##########
@@ -524,11 +525,33 @@ pub fn array_except(args: &[ArrayRef]) -> Result<ArrayRef> {
///
/// See test cases in `array.slt` for more details.
pub fn array_slice(args: &[ArrayRef]) -> Result<ArrayRef> {
- let list_array = as_list_array(&args[0])?;
- let from_array = as_int64_array(&args[1])?;
- let to_array = as_int64_array(&args[2])?;
+ let array_data_type = args[0].data_type();
+ match array_data_type {
+ DataType::List(_) => {
+ let array = as_list_array(&args[0])?;
+ let from_array = as_int64_array(&args[1])?;
+ let to_array = as_int64_array(&args[2])?;
+ general_array_slice::<i32, Int64Type>(array, from_array, to_array)
+ }
+ DataType::LargeList(_) => {
+ let array = as_large_list_array(&args[0])?;
+ let from_array = as_int64_array(&args[1])?;
+ let to_array = as_int64_array(&args[2])?;
+ general_array_slice::<i64, Int64Type>(array, from_array, to_array)
+ }
+ _ => not_impl_err!("array_slice does not support type: {:?}", array_data_type),
+ }
+}
- let values = list_array.values();
+fn general_array_slice<O: OffsetSizeTrait, T: ArrowNumericType<Native = i64>>(
+ array: &GenericListArray<O>,
+ from_array: &PrimitiveArray<T>,
Review Comment:
> T: ArrowNumericType<Native = i64>
it seems like we just need i64array here
How about use Int64Aray?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: support largelist in array_slice [arrow-datafusion]
Posted by "jayzhan211 (via GitHub)" <gi...@apache.org>.
jayzhan211 commented on code in PR #8561:
URL: https://github.com/apache/arrow-datafusion/pull/8561#discussion_r1428621263
##########
datafusion/physical-expr/src/array_expressions.rs:
##########
@@ -524,11 +525,33 @@ pub fn array_except(args: &[ArrayRef]) -> Result<ArrayRef> {
///
/// See test cases in `array.slt` for more details.
pub fn array_slice(args: &[ArrayRef]) -> Result<ArrayRef> {
- let list_array = as_list_array(&args[0])?;
- let from_array = as_int64_array(&args[1])?;
- let to_array = as_int64_array(&args[2])?;
+ let array_data_type = args[0].data_type();
+ match array_data_type {
+ DataType::List(_) => {
+ let array = as_list_array(&args[0])?;
+ let from_array = as_int64_array(&args[1])?;
+ let to_array = as_int64_array(&args[2])?;
+ general_array_slice::<i32, Int64Type>(array, from_array, to_array)
+ }
+ DataType::LargeList(_) => {
+ let array = as_large_list_array(&args[0])?;
+ let from_array = as_int64_array(&args[1])?;
+ let to_array = as_int64_array(&args[2])?;
+ general_array_slice::<i64, Int64Type>(array, from_array, to_array)
+ }
+ _ => not_impl_err!("array_slice does not support type: {:?}", array_data_type),
+ }
+}
- let values = list_array.values();
+fn general_array_slice<O: OffsetSizeTrait, T: ArrowNumericType<Native = i64>>(
+ array: &GenericListArray<O>,
+ from_array: &PrimitiveArray<T>,
Review Comment:
How about use In64Aray?
##########
datafusion/physical-expr/src/array_expressions.rs:
##########
@@ -524,11 +525,33 @@ pub fn array_except(args: &[ArrayRef]) -> Result<ArrayRef> {
///
/// See test cases in `array.slt` for more details.
pub fn array_slice(args: &[ArrayRef]) -> Result<ArrayRef> {
- let list_array = as_list_array(&args[0])?;
- let from_array = as_int64_array(&args[1])?;
- let to_array = as_int64_array(&args[2])?;
+ let array_data_type = args[0].data_type();
+ match array_data_type {
+ DataType::List(_) => {
+ let array = as_list_array(&args[0])?;
+ let from_array = as_int64_array(&args[1])?;
+ let to_array = as_int64_array(&args[2])?;
+ general_array_slice::<i32, Int64Type>(array, from_array, to_array)
+ }
+ DataType::LargeList(_) => {
+ let array = as_large_list_array(&args[0])?;
+ let from_array = as_int64_array(&args[1])?;
+ let to_array = as_int64_array(&args[2])?;
+ general_array_slice::<i64, Int64Type>(array, from_array, to_array)
+ }
+ _ => not_impl_err!("array_slice does not support type: {:?}", array_data_type),
+ }
+}
- let values = list_array.values();
+fn general_array_slice<O: OffsetSizeTrait, T: ArrowNumericType<Native = i64>>(
+ array: &GenericListArray<O>,
+ from_array: &PrimitiveArray<T>,
Review Comment:
How about use Int64Aray?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: support largelist in array_slice [arrow-datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #8561:
URL: https://github.com/apache/arrow-datafusion/pull/8561
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org