[GitHub] [superset] zhaoyongjie commented on pull request #18921: fix: apply url_params in global async query

[GitBox <gi...@apache.org>]

zhaoyongjie commented on pull request #18921:
URL: https://github.com/apache/superset/pull/18921#issuecomment-1051618282


   Oh! Thank for pointing that out! I will check it tonight!
   
   On Sat, Feb 26, 2022 at 08:24 Kenny Kwan ***@***.***> wrote:
   
   > @zhaoyongjie <https://github.com/zhaoyongjie> I believe global async
   > queries have 2 code paths
   > <https://github.com/apache/superset/blob/master/superset/tasks/async_queries.py#L100>.
   > Does superset/explore_json/data also need to be updated in this PR?
   >
   > I applied this patch to our internal fork of v1.3 and verified this fix
   > works when requests are sent to api/v1/chart. However I still see issues
   > when url_params are used with GAQ and the request is sent to
   > superset/explore_json/data.
   >
   > —
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/superset/pull/18921#issuecomment-1051393307>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AAPMKUX7TN4D77BCATARLITU5AMTTANCNFSM5PHAKJ5A>
   > .
   > Triage notifications on the go with GitHub Mobile for iOS
   > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
   > or Android
   > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
   >
   > You are receiving this because you were mentioned.Message ID:
   > ***@***.***>
   >
   -- 
   
   Best regards,
   
   Yongjie
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org