You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "A6AN (via GitHub)" <gi...@apache.org> on 2025/11/20 21:47:01 UTC
[PR] docs: clarify keyword-dependent masking for Connection 'extra' JSON (fixes #58514) [airflow]
A6AN opened a new pull request, #58539:
URL: https://github.com/apache/airflow/pull/58539
What
This PR clarifies that masking for Connection extra JSON fields is keyword-dependent and not applied to every field in the extra JSON. It adds the default sensitive keywords, a short example table showing masking scope, and local preview instructions for maintainers.
Why
The current wording implies all keys in the extra JSON are masked. Issue #58514 demonstrated that only keys containing certain sensitive keywords are redacted. This PR updates the documentation to reflect runtime behavior accurately.
Changes
Replaces the ambiguous paragraph in airflow-core/docs/security/secrets/mask-sensitive-values.rst
Adds the list of default sensitive keywords
Adds a table of examples showing masking behavior
Adds a short note + preview instructions
References
Fixes: #58514
I previewed the docs locally / in-editor and confirm the new section renders as expected.
Happy to adjust phrasing or formatting per maintainers' feedback.
Ayan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs: clarify keyword-dependent masking for Connection 'extra' JSON (fixes #58514) [airflow]
Posted by "A6AN (via GitHub)" <gi...@apache.org>.
A6AN commented on PR #58539:
URL: https://github.com/apache/airflow/pull/58539#issuecomment-3567728308
> Lots of lines duplicated in this PR
Hey, sorry I am new at this can you please guide me at what changes I might need to make to this PR? Sorry for the trouble.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs: clarify keyword-dependent masking for Connection 'extra' JSON (fixes #58514) [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #58539:
URL: https://github.com/apache/airflow/pull/58539#issuecomment-3560178433
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [prek-hooks]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-prek-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/airflow-core/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices).
- Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs: clarify keyword-dependent masking for Connection 'extra' JSON (fixes #58514) [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk closed pull request #58539: docs: clarify keyword-dependent masking for Connection 'extra' JSON (fixes #58514)
URL: https://github.com/apache/airflow/pull/58539
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs: clarify keyword-dependent masking for Connection 'extra' JSON (fixes #58514) [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #58539:
URL: https://github.com/apache/airflow/pull/58539#issuecomment-3568347743
> Hey, sorry I am new at this can you please guide me at what changes I might need to make to this PR? Sorry for the trouble
Well, I am looking at your changes and they are duplicating lines. Look yourself - you need to be able to basically understand what changes you are doing. If this is somehow AI generated change and you expect maintainers to debug your AI then it's better you don't do it at all.
I am closing it, make sure you know what you are doing before submitting the PR and taking time of maintainers.
Dont' be sorry for the trouble, just don't make the trouble in the first place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs: clarify keyword-dependent masking for Connection 'extra' JSON (fixes #58514) [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #58539:
URL: https://github.com/apache/airflow/pull/58539#issuecomment-3567185933
Lots of lines duplicated in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org